[ 
https://issues.apache.org/jira/browse/CASSANDRA-5351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864196#comment-13864196
 ] 

Lyuben Todorov commented on CASSANDRA-5351:
-------------------------------------------

[~krummas] I've rebased the [branch|https://github.com/lyubent/cassandra/] to 
the latest trunk, there are some issues with the rebase and I'm in the process 
of addresing said issues, but I though It'd be useful for you to see the 
updated branch. I'll look at the issues you noted once I sort out the rebase 
problems (fwiw the problem is with tables getting compacted before the repair 
command's completion and causing null pointer exceptions at 
SSTableReader#getApproximateKeyCount)

> Avoid repairing already-repaired data by default
> ------------------------------------------------
>
>                 Key: CASSANDRA-5351
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5351
>             Project: Cassandra
>          Issue Type: Task
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Lyuben Todorov
>              Labels: repair
>             Fix For: 2.1
>
>         Attachments: 5351_node1.log, 5351_node2.log, 5351_node3.log, 
> 5351_nodetool.log
>
>
> Repair has always built its merkle tree from all the data in a columnfamily, 
> which is guaranteed to work but is inefficient.
> We can improve this by remembering which sstables have already been 
> successfully repaired, and only repairing sstables new since the last repair. 
>  (This automatically makes CASSANDRA-3362 much less of a problem too.)
> The tricky part is, compaction will (if not taught otherwise) mix repaired 
> data together with non-repaired.  So we should segregate unrepaired sstables 
> from the repaired ones.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to