[
https://issues.apache.org/jira/browse/CASSANDRA-6503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864313#comment-13864313
]
Jason Brown edited comment on CASSANDRA-6503 at 1/7/14 10:10 PM:
-----------------------------------------------------------------
[~yukim] I can see how modifying closeAndOpenReader() would help here, but
there's one wrinkle (I think): if we defer renaming the files from
closeAndOpenReader(), we would need to rename the *open* SSTR, and there's a
note in FileUtils.renameWithConfirm():
{code} // this is not FSWE because usually when we see it it's because
we didn't close the file before renaming it,
// and Windows is picky about that.{code}
So I'm not sure about the deferred rename of the SSTR, assuming we care about
Windows.
was (Author: jasobrown):
[~yukim] I can see how modifying closeAndOpenReader() would help here, but
there's one wrinkle (I think): if we defer renaming the files from
closeAndOpenReader(), we would need to rename the *open* SSTR, and there's a
note in FileUtils.renameWithConfirm():
{code} // this is not FSWE because usually when we see it it's because
we didn't close the file before renaming it,
// and Windows is picky about that.{code}
So I'm not sure about the deferred rename, assuming we care about Windows.
> sstables from stalled repair sessions become live after a reboot and can
> resurrect deleted data
> -----------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-6503
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6503
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jeremiah Jordan
> Assignee: Yuki Morishita
> Priority: Minor
> Fix For: 1.2.14, 2.0.5
>
> Attachments: 6503_c1.2-v1.patch
>
>
> The sstables streamed in during a repair session don't become active until
> the session finishes. If something causes the repair session to hang for
> some reason, those sstables will hang around until the next reboot, and
> become active then. If you don't reboot for 3 months, this can cause data to
> resurrect, as GC grace has expired, so tombstones for the data in those
> sstables may have already been collected.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
