[ 
https://issues.apache.org/jira/browse/CASSANDRA-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865818#comment-13865818
 ] 

Aleksey Yeschenko commented on CASSANDRA-6505:
----------------------------------------------

bq. Nit: Is there a reason to add GLOBAL_SHARD_INDEX_OFFSET rather than say 
-x-1 ("à la" binary search) for global shards? Not that it doesn't work as it 
is, just that negating would seem slightly more natural/simpler to me.

I used to have just '-x', but that obviously doesn't work for 0. And 'MIN_VALUE 
+ x' seemed cleaner than '-x - 1'.

The rest makes sense to me, will do.

> counters++ global shards 2.0 back port
> --------------------------------------
>
>                 Key: CASSANDRA-6505
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6505
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Aleksey Yeschenko
>            Assignee: Aleksey Yeschenko
>             Fix For: 2.0.5
>
>
> CASSANDRA-6504 introduces a new type of shard - 'global' - to 2.1. To enable 
> live upgrade from 2.0 to 2.1, it's necessary that 2.0 nodes are able to 
> understand the new 'global' shards in the counter contexts.
> 2.0 nodes will not produce 'global' shards, but must contain the merge logic.
> It isn't a trivial code change ("non-trivial code in a non-trivial part of 
> the code"), hence this separate JIRA issue.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to