[
https://issues.apache.org/jira/browse/CASSANDRA-6596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899256#comment-13899256
]
Benedict commented on CASSANDRA-6596:
-------------------------------------
Mostly LGTM. A couple of sort-of-nits:
1) Inter DC should default to 0/off. No point duplicating the non-inter-DC rate
limit.
2) I think there should be two static instances, and the old-style static
method to return the correct one and reset the rate limit. I don't think mixing
the static setting in a constructor is very neat, nor is the instance method
mayUpdateThroughput, which should be static anyway.
That said, neither of this are absolutely necessary. So +1.
I also agree about the bug. I would say the easiest fix is to redefine the
multiplier, as opposed to changing the snippet you pasted.
> Split out outgoing stream throughput within a DC and inter-DC
> -------------------------------------------------------------
>
> Key: CASSANDRA-6596
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6596
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jeremy Hanna
> Assignee: Vijay
> Priority: Minor
> Fix For: 2.1
>
> Attachments: 0001-CASSANDRA-6596.patch
>
>
> Currently the outgoing stream throughput setting doesn't differentiate
> between when it goes to another node in the same DC and when it goes to
> another DC across a potentially bandwidth limited link. It would be nice to
> have that split out so that it could be tuned for each type of link.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
