[
https://issues.apache.org/jira/browse/CASSANDRA-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13915840#comment-13915840
]
Sylvain Lebresne commented on CASSANDRA-6689:
---------------------------------------------
2 remarks that I remarked while skimming over the patch (those are more
codestyle than anything but well):
* there's tons of method whose name starts with an underscore. I'd really
rather avoid that since it's inconsistent with the code base (and given the
time it took us a few years back to remove all underscores to get the code
consistent, I'd rather not reintroduce some now).
* why changing all the ByteBuffer.hasArray() calls to !ByteBuffer.isDirect()?
In almost all cases, hasArray() is called to guard some latter calls to array()
and/or arrayOffset() and the [ByteBuffer
javadoc|http://docs.oracle.com/javase/6/docs/api/java/nio/ByteBuffer.html#hasArray()]
is pretty explicit on the fact that hasArray() is *the* correct method to call
in that case.
> Partially Off Heap Memtables
> ----------------------------
>
> Key: CASSANDRA-6689
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6689
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Benedict
> Assignee: Benedict
> Fix For: 2.1 beta2
>
>
> Move the contents of ByteBuffers off-heap for records written to a memtable.
> (See comments for details)
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
