[ 
https://issues.apache.org/jira/browse/CASSANDRA-6811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925321#comment-13925321
 ] 

Vijay commented on CASSANDRA-6811:
----------------------------------

Thanks, +1 and committed...

Inlined the comparison and replaced the empty string with "?"

{code}
Note: Ownership information does not include topology; for complete 
information, specify a keyspace

Datacenter: datacenter1
==========
Address         Rack        Status State   Load            Owns                
Token                                       

17.198.227.158  rack1       Up     Joining 9.44 KB         ?                   
-7564491331177403445                        
17.198.227.157  rack1       Up     Normal  14.03 KB        100.00%             
-2195150324932625854                        

-bash-4.1$ ./apache-cassandra-1.2.15-SNAPSHOT/bin/nodetool ring
Note: Ownership information does not include topology; for complete 
information, specify a keyspace

Datacenter: datacenter1
==========
Address         Rack        Status State   Load            Owns                
Token                                       
                                                                               
-2195150324932625854                        
17.198.227.158  rack1       Up     Normal  10.77 KB        70.89%              
-7564491331177403445                        
17.198.227.157  rack1       Up     Normal  14.03 KB        29.11%              
-2195150324932625854                        

-bash-4.1$ ./apache-cassandra-1.2.15-SNAPSHOT/bin/nodetool ring
Note: Ownership information does not include topology; for complete 
information, specify a keyspace

Datacenter: datacenter1
==========
Address         Rack        Status State   Load            Owns                
Token                                       
                                                                               
-2195150324932625854                        
17.198.227.158  rack1       Up     Leaving 10.77 KB        70.89%              
-7564491331177403445                        
17.198.227.157  rack1       Up     Normal  14.03 KB        29.11%              
-2195150324932625854                       
{code}

> nodetool no longer shows node joining
> -------------------------------------
>
>                 Key: CASSANDRA-6811
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6811
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Brandon Williams
>            Assignee: Vijay
>            Priority: Minor
>             Fix For: 1.2.16
>
>         Attachments: ringfix.txt
>
>
> When we added effective ownership output to nodetool ring/status, we 
> accidentally began excluding joining nodes because we iterate the ownership 
> maps instead of the the endpoint to token map when printing the output, and 
> the joining nodes don't have any ownership.  The simplest thing to do is 
> probably iterate the token map instead, and not output any ownership info for 
> joining nodes.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to