[ https://issues.apache.org/jira/browse/CASSANDRA-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13932510#comment-13932510 ]
Jonathan Ellis edited comment on CASSANDRA-5483 at 3/12/14 10:14 PM: --------------------------------------------------------------------- Thanks. I'm going to bikeshed the messages a bit: - {{Starting repair command #3, repairing 2 ranges for keyspace system_traces (seq=true, full=true)}} -> {{Repairing 2 ranges for system_traces.\{sessions, events\} (seq=true, full=true)}} - {{[repair #fedc3790-a9fa-11e3-ab61-2387bbb38302] new session: will sync /127.0.0.1, /127.0.0.3 on range (-3074457345618258603,3074457345618258602] for system_traces.[sessions, events]}} -> {{New session fedc3790-a9fa-11e3-ab61-2387bbb38302 will sync range (-3074457345618258603,3074457345618258602]}} - All the rest: omit the [repair] session id since that's already traced, and capitalize the first word - Add a message if there's nothing to stream What does it log when there *is* something to stream? was (Author: jbellis): Thanks. I'm going to bikeshed the messages a bit: - {{Starting repair command #3, repairing 2 ranges for keyspace system_traces (seq=true, full=true)}} -> {{Repairing 2 ranges for system_traces.{sessions, events} (seq=true, full=true)}} - {{[repair #fedc3790-a9fa-11e3-ab61-2387bbb38302] new session: will sync /127.0.0.1, /127.0.0.3 on range (-3074457345618258603,3074457345618258602] for system_traces.[sessions, events]}} -> {{New session #fedc3790-a9fa-11e3-ab61-2387bbb38302 will sync range (-3074457345618258603,3074457345618258602]}} - All the rest: omit the session id since that's already traced, and capitalize the first word - Add a message if there's nothing to stream What does it log when there *is* something to stream? > Repair tracing > -------------- > > Key: CASSANDRA-5483 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5483 > Project: Cassandra > Issue Type: Improvement > Components: Tools > Reporter: Yuki Morishita > Assignee: Ben Chan > Priority: Minor > Labels: repair > Attachments: 5483-full-trunk.txt, > 5483-v06-04-Allow-tracing-ttl-to-be-configured.patch, > 5483-v06-05-Add-a-command-column-to-system_traces.events.patch, > 5483-v06-06-Fix-interruption-in-tracestate-propagation.patch, > 5483-v07-07-Better-constructor-parameters-for-DebuggableThreadPoolExecutor.patch, > 5483-v07-08-Fix-brace-style.patch, > 5483-v07-09-Add-trace-option-to-a-more-complete-set-of-repair-functions.patch, > 5483-v07-10-Correct-name-of-boolean-repairedAt-to-fullRepair.patch, > ccm-repair-test, test-5483-system_traces-events.txt, > trunk@4620823-5483-v02-0001-Trace-filtering-and-tracestate-propagation.patch, > trunk@4620823-5483-v02-0002-Put-a-few-traces-parallel-to-the-repair-logging.patch, > tr...@8ebeee1-5483-v01-001-trace-filtering-and-tracestate-propagation.txt, > tr...@8ebeee1-5483-v01-002-simple-repair-tracing.txt, > v02p02-5483-v03-0003-Make-repair-tracing-controllable-via-nodetool.patch, > v02p02-5483-v04-0003-This-time-use-an-EnumSet-to-pass-boolean-repair-options.patch, > v02p02-5483-v05-0003-Use-long-instead-of-EnumSet-to-work-with-JMX.patch > > > I think it would be nice to log repair stats and results like query tracing > stores traces to system keyspace. With it, you don't have to lookup each log > file to see what was the status and how it performed the repair you invoked. > Instead, you can query the repair log with session ID to see the state and > stats of all nodes involved in that repair session. -- This message was sent by Atlassian JIRA (v6.2#6252)