[ 
https://issues.apache.org/jira/browse/CASSANDRA-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13946318#comment-13946318
 ] 

Benedict edited comment on CASSANDRA-6689 at 3/25/14 9:19 AM:
--------------------------------------------------------------

-Agreed-. Pushed updated version to branch, which also modifies the 
FileUtils.clean() code to be the neater direct cast, and to check for the 
possibility by actually attempting a clean of a DirectByteBuffer.

bq. and just fail over to the heap allocation

I've opted for dying with an error message, and prompting the user to change 
the config, but while this is less in keeping with what is the normal approach, 
I think the danger of eating up all your memory (and possibly crashing with OOM 
at random times) is bad enough to warrant the break from the norm.


was (Author: benedict):
Agreed. Pushed updated version to branch, which also modifies the 
FileUtils.clean() code to be the neater direct cast, and to check for the 
possibility by actually attempting a clean of a DirectByteBuffer.

> Partially Off Heap Memtables
> ----------------------------
>
>                 Key: CASSANDRA-6689
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6689
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>              Labels: performance
>             Fix For: 2.1 beta2
>
>         Attachments: CASSANDRA-6689-final-changes.patch, 
> CASSANDRA-6689-small-changes.patch
>
>
> Move the contents of ByteBuffers off-heap for records written to a memtable.
> (See comments for details)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to