[
https://issues.apache.org/jira/browse/CASSANDRA-6931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954505#comment-13954505
]
Aleksey Yeschenko edited comment on CASSANDRA-6931 at 3/29/14 11:14 PM:
------------------------------------------------------------------------
Pushed to https://github.com/iamaleksey/cassandra/commits/6931
On trunk merge will get rid of the special casing of VERSION_12 in
BatchlogManager#processBatchlogPage() and StorageProxy#syncWriteToBatchlog().
was (Author: iamaleksey):
Pushed to https://github.com/iamaleksey/cassandra/commits/6931
On trunk merge will get rid of all pre-2.0 mutation serialization code and
VERSION_12 special casing.
> BatchLogManager shouldn't serialize mutations with version 1.2 in 2.1.
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-6931
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6931
> Project: Cassandra
> Issue Type: Bug
> Reporter: Sylvain Lebresne
> Assignee: Aleksey Yeschenko
> Fix For: 2.1 beta2
>
>
> BatchLogManager serialize and deserialize mutations using
> MessagingService.VERSION_12 and this is hardcoded. Meaning that it does that
> in 2.0, 2.1 and trunk, even though in 2.1 the 1.2 format is not properly
> serialized properly since [this
> commit|https://github.com/apache/cassandra/commit/cca65d7c1638dcd9370b080f08fd55faefc2733e]
> (meaning that I'm pretty sure batch logs on super columns is broken on 2.1
> currently). And keeping the 1.2 format indefinitely just for batchlog is
> unrealistic.
> So batchlog needs to do something like hints, record the messaging format
> used to encode every mutation and use that for deserialization, but always
> serialize with the current format.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
