[
https://issues.apache.org/jira/browse/CASSANDRA-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955474#comment-13955474
]
Joshua McKenzie commented on CASSANDRA-4050:
--------------------------------------------
{quote}
the skipBytes method ensures it never goes above this
{quote}
How is skipBytes protecting against blowing past our limit? (note: me just
being dense here is not out of the question)
{code:java, title=skipBytes}
64 public int skipBytes(int n) throws IOException
65 {
66 if (n <= 0)
67 return 0;
68 seek(getPosition() + n);
69 return position;
70 }
{code}
It looks like this exposes seek() to the outside world with a protection
against negative inputs but not much else. That being said - the old code
looks like it has the same potential problem:
{code:java, title=old code}
public int skipBytes(int n) throws IOException
{
seekInternal(getPosition() + n);
return position;
}
{code}
> Unable to remove snapshot files on Windows while original sstables are live
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-4050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4050
> Project: Cassandra
> Issue Type: Bug
> Environment: Windows 7
> Reporter: Jim Newsham
> Assignee: Joshua McKenzie
> Priority: Minor
> Attachments: CASSANDRA-4050_v1.patch
>
>
> I'm using Cassandra 1.0.8, on Windows 7. When I take a snapshot of the
> database, I find that I am unable to delete the snapshot directory (i.e., dir
> named "{datadir}\{keyspacename}\snapshots\{snapshottag}") while Cassandra is
> running: "The action can't be completed because the folder or a file in it
> is open in another program. Close the folder or file and try again" [in
> Windows Explorer]. If I terminate Cassandra, then I can delete the directory
> with no problem.
> I expect to be able to move or delete the snapshotted files while Cassandra
> is running, as this should not affect the runtime operation of Cassandra.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
