[
https://issues.apache.org/jira/browse/CASSANDRA-7028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969015#comment-13969015
]
Joshua McKenzie edited comment on CASSANDRA-7028 at 4/14/14 11:49 PM:
----------------------------------------------------------------------
Tests pass, looks good. +1 from me though I do have 1 question:
What's our reasoning as to what libraries we store in {basedir}/lib and what
libraries we expect to pull using ant into build/lib/*? antlr was previously
housed in {basedir}/lib and it looks like you put the antlr runtime and
stringtemplate into that folder, however the antlr full is pulled into
build/lib. Any insight into the reasoning there?
Edit: just saw your comment. I think you can include via --binary but yeah -
that comes out to over 2MB. If we just had the ant process dnload these libs
into build/lib/jars and referenced those during the build, we wouldn't have to
worry about manual copying around, no?
was (Author: joshuamckenzie):
Tests pass, looks good. +1 from me though I do have 1 question:
What's our reasoning as to what libraries we store in {basedir}/lib and what
libraries we expect to pull using ant into build/lib/*? antlr was previously
housed in {basedir}/lib and it looks like you put the antlr runtime and
stringtemplate into that folder, however the antlr full is pulled into
build/lib. Any insight into the reasoning there?
> Allow C* to compile under java 8
> --------------------------------
>
> Key: CASSANDRA-7028
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7028
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Dave Brosius
> Assignee: Dave Brosius
> Priority: Minor
> Fix For: 3.0
>
> Attachments: 7028.txt, 7028_v2.txt, 7028_v3.txt
>
>
> antlr 3.2 has a problem with java 8, as described here:
> http://bugs.java.com/bugdatabase/view_bug.do?bug_id=8015656
> updating to antlr 3.5.2 solves this, however they have split up the jars
> differently, which adds some changes, but also the generation of
> CqlParser.java causes a method to be too large, so i needed to split that
> method to reduce the size of it.
> (patch against trunk)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
