[ 
https://issues.apache.org/jira/browse/CASSANDRA-7028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969041#comment-13969041
 ] 

Joshua McKenzie commented on CASSANDRA-7028:
--------------------------------------------

Actually - v3 doesn't appear to apply to a clean repo clone on trunk:

{code:title=errors}
error: missing binary patch data for 'lib/antlr-runtime-3.5.2.jar'
error: binary patch does not apply to 'lib/antlr-runtime-3.5.2.jar'
error: lib/antlr-runtime-3.5.2.jar: patch does not apply
error: missing binary patch data for 'lib/stringtemplate-4.0.2.jar'
error: binary patch does not apply to 'lib/stringtemplate-4.0.2.jar'
error: lib/stringtemplate-4.0.2.jar: patch does not apply
{code}

The patch works on a repo I was mucking around with but on a clean clone, it's 
looking for the files that aren't included.

This goes back to my earlier question - can we have these pulled down the way I 
had in the _v2 patch and have them read from build/lib, or is there something 
I'm missing?

> Allow C* to compile under java 8
> --------------------------------
>
>                 Key: CASSANDRA-7028
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7028
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: 7028.txt, 7028_v2.txt, 7028_v3.txt
>
>
> antlr 3.2 has a problem with java 8, as described here: 
> http://bugs.java.com/bugdatabase/view_bug.do?bug_id=8015656
> updating to antlr 3.5.2 solves this, however they have split up the jars 
> differently, which adds some changes, but also the generation of 
> CqlParser.java causes a method to be too large, so i needed to split that 
> method to reduce the size of it.
> (patch against trunk)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to