[ 
https://issues.apache.org/jira/browse/CASSANDRA-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976402#comment-13976402
 ] 

Dave Brosius commented on CASSANDRA-7038:
-----------------------------------------

patch(es) LGTM +1

as a side note, and unrelated to this patch, nodetool rebuild_index silently 
ignores bad index names, so it appears that a rebuild of a fictional index 
succeeded.

ie

./nodetool rebuild_index ks cf foobar;

seems to complete successfully after churning for a short time.

probably not ideal.

> Nodetool rebuild_index requires named indexes argument
> ------------------------------------------------------
>
>                 Key: CASSANDRA-7038
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7038
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>            Reporter: Sam Tunnicliffe
>            Assignee: Sam Tunnicliffe
>            Priority: Trivial
>         Attachments: 7038-1.2.txt, 7038-2.1.txt
>
>
> In addition to explicitly listing the indexes to be rebuilt, nodetool 
> rebuild_indexes will also accept just keyspace & columnfamily arguments, 
> indicating that all indexes for that ks/cf should be rebuilt.
> This doesn't actually work as CFS.rebuildSecondaryIndex requires the explicit 
> list. In the 2 arg version, nodetool just passes an empty list here and so 
> the rebuild becomes a no-op. As this has been the case since CASSANDRA-3860 
> (AFAICT, 80ea03f is the commit that removed this) we may as well just remove 
> the option from nodetool, patch attached to do that. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to