[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977104#comment-13977104
]
Tyler Hobbs commented on CASSANDRA-6572:
----------------------------------------
In addition to Benedict's comments, there are a couple of other things to
change:
* Substring checks won't cut it for {{isSystemOrTraceKS()}}. Instead, let the
query get parsed first and then check its keyspace. Unfortunately, it doesn't
look like the Statement subclasses expose any keyspace-related info right now,
so you may need to add that yourself.
* When replaying, don't read every file upfront. I would make an Iterator that
transparently iterates over the files and reads one query string at a time
* As Benedict mentioned, you don't want to base64 the query string. I'm
guessing you did that to avoid spaces and newlines. Instead, just write the
length of the query string out as an integer before writing the query string.
When reading, you'll first read the length and then you can just read that many
bytes.
> Workload recording / playback
> -----------------------------
>
> Key: CASSANDRA-6572
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6572
> Project: Cassandra
> Issue Type: New Feature
> Components: Core, Tools
> Reporter: Jonathan Ellis
> Assignee: Lyuben Todorov
> Fix For: 2.1.1
>
> Attachments: 6572-trunk.diff
>
>
> "Write sample mode" gets us part way to testing new versions against a real
> world workload, but we need an easy way to test the query side as well.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
