[ 
https://issues.apache.org/jira/browse/CASSANDRA-6421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14005203#comment-14005203
 ] 

Michael Shuler commented on CASSANDRA-6421:
-------------------------------------------

6421.txt looks complete for 1.2 nodetool options (rebased that patch on 1.2).

All of the following is purely based on the output of nodetool options help on 
each version.
[~cscetbon], let me know if my notes below are not clear. These are the 
differences between the nodetool options available in the 1.2 version of the 
completion file you provided and nodetool option in 2.0 and 2.1 branches, and 
is why I asked in January if you could rebase on trunk at that time. (2.1 was 
forked since that time, and nodetool options are the same in 2.1/trunk 
currently) Feature additions typically get added to new major revisions.

Ideally, if you could flesh out the differences between the versions and attach 
a completion file for each branch to this ticket, that would be great!  If you 
have limited time and could flesh out the changes needed for just 2.1 branch, 
that would be the branch to work from.

There is no current urgent need to get a new 1.2 release done, so while the 1.2 
version of the completion is functional, it is only somewhat forward compatible 
2.0 and 2.1. (It would be a lot simpler to have a version for 2.1 and backport 
by just editing a few lines)

----
2.0 changes since 1.2:
- commands to remove from 1.2 completion to be 2.0 complete:
-- predictconsistency

- commands to add to 1.2 completion to be 2.0 complete:
-- compactionhistory
-- disableautocompaction
-- enableautocompaction
-- getLoggingLevels
-- reloadtriggers
-- setLoggingLevel
-- taketoken
-- truncatehints

----
2.1 changes since 1.2:
- commands to remove from 1.2 completion to be 2.1 complete:
-- predictconsistency

- commands to add to 1.2 completion to be 2.1 complete:
-- compactionhistory
-- disableautocompaction
-- enableautocompaction
-- getlogginglevels
-- invalidatecountercache
-- listsnapshots
-- reloadtriggers
-- setlogginglevel
-- stopdaemon
-- taketoken
-- truncatehints

----
2.1 changes since 2.0 (for a bit more clarity):
- commands to remove from (non-existent, yet) 2.0 completion to be 2.1 complete:
-- getLoggingLevels
-- setLoggingLevel

- commands to add to (non-existent, yet) 2.0 completion to be 2.1 complete:
-- getlogginglevels
-- invalidatecountercache
-- listsnapshots
-- setlogginglevel
-- stopdaemon

> Add bash completion to nodetool
> -------------------------------
>
>                 Key: CASSANDRA-6421
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6421
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Cyril Scetbon
>            Assignee: Michael Shuler
>            Priority: Trivial
>             Fix For: 2.1 rc1
>
>         Attachments: 6421.txt
>
>
> You can find the bash-completion file at 
> https://raw.github.com/cscetbon/cassandra/nodetool-completion/etc/bash_completion.d/nodetool
> it uses cqlsh to get keyspaces and namespaces and could use an environment 
> variable (not implemented) to get access which cqlsh if authentification is 
> needed. But I think that's really a good start :)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to