[
https://issues.apache.org/jira/browse/CASSANDRA-7160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Shuler updated CASSANDRA-7160:
--------------------------------------
Attachment: 7160.txt
Patch for cassandra attached. I assumed that cassandra-stress should remain in
the cassandra debian package and not be moved to the cassandra-tools deb.
[~brandon.williams] let me know if my assumption was incorrect.
Still ToDo:
- patch ccm for version >= 2.1 to get path changes to tools/bin/...
(we should probably commit to c* and ccm pretty closely, so tests don't go
haywire too much)
{noformat}
(master)mshuler@hana:~/git/ccm$ for i in json2sstable sstable2json
sstablesplit; do echo == $i ==; grep -r $i .; done
== json2sstable ==
== sstable2json ==
./ccmlib/cmds/node_cmds.py: return "Call sstable2json on the sstables of
this node"
./ccmlib/cmds/node_cmds.py:
self.node.run_sstable2json(self.keyspace, self.datafile, self.column_families,
self.options.enumerate_keys)
./ccmlib/node.py: def run_sstable2json(self, keyspace=None, datafile=None,
column_families=None, enumerate_keys=False):
./ccmlib/node.py: sstable2json = common.join_bin(cdir, 'bin',
'sstable2json')
./ccmlib/node.py: args = [ sstable2json , file ]
== sstablesplit ==
./ccmlib/cmds/node_cmds.py: "sstablesplit",
./ccmlib/cmds/node_cmds.py: return "Run sstablesplit on the sstables of
this node"
./ccmlib/cmds/node_cmds.py: usage = "usage: ccm node_name sstablesplit
[options] [file]"
./ccmlib/cmds/node_cmds.py:
self.node.run_sstablesplit(datafile=self.datafile, size=self.size)
./ccmlib/cmds/node_cmds.py:
self.node.run_sstablesplit(keyspace=self.keyspace,
column_families=self.column_families, size=self.size)
./ccmlib/node.py: def run_sstablesplit(self, datafile=None, size=None,
keyspace=None, column_families=None):
./ccmlib/node.py: sstablesplit = common.join_bin(cdir, 'bin',
'sstablesplit')
./ccmlib/node.py: subprocess.call( [sstablesplit, '-s',
str(size), f], cwd=os.path.join(cdir, 'bin'), env=env )
./ccmlib/node.py: subprocess.call( [sstablesplit, f],
cwd=os.path.join(cdir, 'bin'), env=env )
./README: - non nodetool-based command-line options fail (sstablesplit,
scrub, etc)
{noformat}
(a search through dtest did not reveal any direct calls to any of the moved
scripts)
> clean up tools/bin
> ------------------
>
> Key: CASSANDRA-7160
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7160
> Project: Cassandra
> Issue Type: Improvement
> Components: Packaging
> Reporter: Brandon Williams
> Assignee: Michael Shuler
> Priority: Minor
> Fix For: 2.1 rc1
>
> Attachments: 7160.txt
>
>
> Right now we have most utils in bin/, but sstablemetadata is an outlier in
> tools/bin. For packaging, we don't care what the source directory is, we put
> everything in /usr/bin. We want to keep some things out of users' hands
> unless they know what they're doing (like sstable2json) so I propose that we
> break these things out into a companion cassandra-tools package that will
> depend on cassandra.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
