[
https://issues.apache.org/jira/browse/CASSANDRA-7273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033928#comment-14033928
]
Brandon Williams commented on CASSANDRA-7273:
---------------------------------------------
I have to admit, this is not how I envisioned this patch at all, but I like
what you've done! Especially in the releasing of metrics, since that always
felt error prone (and indeed, I screwed it up.) One nit: please set your IDE
to collapse imports when there are 3 or more to asterisk instead (it actually
undid some existing instances of this.)
There are now a bunch of stats in GCF that aren't in KS... we should have
parity there, though at this point I feel like the KS level is out of place
somehow, perhaps because GCF is so much more elegant ;) We should probably at
least apply your releasing pattern there as well.
> expose global ColumnFamily metrics
> ----------------------------------
>
> Key: CASSANDRA-7273
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7273
> Project: Cassandra
> Issue Type: New Feature
> Reporter: Richard Wagner
> Assignee: Brandon Williams
> Priority: Minor
> Labels: lhf
> Fix For: 1.2.17
>
> Attachments: 7273-2_1_branch-v1.txt
>
>
> It would be very useful to have cassandra expose ColumnFamily metrics that
> span all column families. A general purpose cassandra monitoring system built
> up around the current ColumnFamily metrics really only has a couple of
> choices right now: publish metrics for all column families or fetch metrics
> for all column families, aggregate them and then publish the aggregated
> metrics. The first can be quite expensive for the downstream monitoring
> system and the second is a piece of work that it seems is better pushed into
> cassandra itself.
> Perhaps these global ColumnFamily metrics could be published under a name of:
> org.apache.cassandra.metrics:type=(ColumnFamily|IndexColumnFamily),name=(Metric
> name)
> (Same as existing ColumnFamily metrics, but with no keyspace or scope.)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
