[
https://issues.apache.org/jira/browse/CASSANDRA-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Yeschenko updated CASSANDRA-7515:
-----------------------------------------
Attachment: 7518-nits-bikeshed.txt
LGTM, +1
Attaching a minor bikeshed/nits patch on top (fixes CLS#allocate() comments,
removes some unrelated unused imports + tiny bikeshed in Keyspace#apply() - we
prefer to not use 'final' for local variables/method args, unless needed).
> Clean up remains of non-working stack-allocation optimisation
> -------------------------------------------------------------
>
> Key: CASSANDRA-7515
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7515
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Aleksey Yeschenko
> Assignee: Benedict
> Priority: Trivial
> Fix For: 2.1.1
>
> Attachments: 7518-nits-bikeshed.txt
>
>
> Can make Allocation fields final
> (https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogSegment.java#L581-L585)
> and get rid of the most likely redundant clone()
> (https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/Memtable.java#L158-L160)
> + remove the misleading comments.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
