[ 
https://issues.apache.org/jira/browse/CASSANDRA-7735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093476#comment-14093476
 ] 

Benedict commented on CASSANDRA-7735:
-------------------------------------

LGTM.

nit: BatchStatement, ModificationStatement, Mutation, QueryState each have an 
unused Frame import, ResponseVerbHandler has an unused IMutation import

> Remove ref-counting of netty buffers
> ------------------------------------
>
>                 Key: CASSANDRA-7735
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7735
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Benedict
>            Assignee: T Jake Luciani
>            Priority: Critical
>              Labels: correctness, performance
>             Fix For: 2.1.0
>
>         Attachments: 7735.txt
>
>
> This has turned out to be more bug prone than we'd hoped, and it no longer 
> seems to be a justified risk factor, since the performance gains were 
> generally quite modest. When there's some time we can reengineer the API to 
> make it safer to produce more obviously correct usage, but in the meantime I 
> propose rolling back this change before general availability of 2.1



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to