[ 
https://issues.apache.org/jira/browse/CASSANDRA-7562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095746#comment-14095746
 ] 

Tyler Hobbs commented on CASSANDRA-7562:
----------------------------------------

This looks pretty good to me so far.

Review comments:
* Can you remove {{StdLibMath.java}}?
* Unused import in {{Auth.java}}
* When generating the class name, it would be good to include the namespace and 
function name.  You can keep the incrementing int on the end to guarantee 
uniqueness.
* Can you add unit tests to cover compilation errors and whatever causes 
NoSuchMethodException to be thrown?
* The cqlsh grammar doesn't handle functions with zero parameters.  Let's fix 
that here so that we don't forget about it.

> Java source code for UDFs
> -------------------------
>
>                 Key: CASSANDRA-7562
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7562
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Robert Stupp
>            Assignee: Robert Stupp
>             Fix For: 3.0
>
>         Attachments: 7562.txt
>
>
> Purpose of this ticket to add support for Java source code for user defined 
> functions (CASSANDRA-7395)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to