[ https://issues.apache.org/jira/browse/CASSANDRA-7795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103634#comment-14103634 ]
Benedict commented on CASSANDRA-7795: ------------------------------------- LGTM, +1 Might want to have a quick look at StreamTask.prepare(), which calls .maybeCompleted() without holding the object monitor. which may be a very very unlikely race condition. > Make StreamReceiveTask thread safe and GC friendly > -------------------------------------------------- > > Key: CASSANDRA-7795 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7795 > Project: Cassandra > Issue Type: Bug > Reporter: Yuki Morishita > Assignee: Yuki Morishita > Priority: Minor > Labels: streaming > Fix For: 2.0.10 > > Attachments: > 0001-Make-StreamReceiveTask-thread-safe-and-gc-friendly.patch > > > StreamReceiveTask is not thread safe when stream session is aborted and > completion task is running. > Also, StreamReceiveTask keeps references to SSTableWriter until completion > task runs and session completes. Currently, StreamReceiveTask's completion > task runs on StorageService's NonPeriodicTask and it may take longer to > execute. > Patch attached to fix above. -- This message was sent by Atlassian JIRA (v6.2#6252)