[
https://issues.apache.org/jira/browse/CASSANDRA-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104339#comment-14104339
]
Robert Stupp commented on CASSANDRA-7606:
-----------------------------------------
Just some minor comments:
* please exchange {{ConfigurationException}} with {{InvalidRequestException}}
in both CreateTriggerStatement and DropTriggerStatement
* In CreateTriggerStatementTest add this test (just for safety):
{noformat}
@Test
public void testDropTriggerExistsFail() throws Throwable
{
createTable("CREATE TABLE %s (a int, b int, c int, PRIMARY KEY (a))");
try
{
execute("DROP TRIGGER trigger_1 ON %s");
Assert.fail();
}
catch (ConfigurationException e)
{
}
}
{noformat}
* nit: split line #590 in {{Cql.g}} before {{K_ON}} - just for readability
> Add IF [NOT] EXISTS to CREATE/DROP trigger
> ------------------------------------------
>
> Key: CASSANDRA-7606
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7606
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Robert Stupp
> Assignee: Benjamin Lerer
> Priority: Minor
> Labels: cql, docs
> Fix For: 2.1.1
>
> Attachments: CASSANDRA-7606.txt
>
>
> All CREATE/DROP statements support IF [NOT] EXISTS - except CREATE/DROP
> trigger.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
