[ 
https://issues.apache.org/jira/browse/CASSANDRA-7719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127935#comment-14127935
 ] 

Benedict commented on CASSANDRA-7719:
-------------------------------------

bq. Don't use String.format in logger.trace, use parameterized messages. Like

More important than this is to guard the logger.trace() call with 
logger.isTraceEnabled(), so that it is optimised away when not enabled. If 
String.format buys you more useful formatting it can be justified, but here it 
looks like the logger can cope with your params just as well.

> Add PreparedStatements related metrics
> --------------------------------------
>
>                 Key: CASSANDRA-7719
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7719
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Michaël Figuière
>            Assignee: T Jake Luciani
>            Priority: Minor
>             Fix For: 2.1.1
>
>         Attachments: 7719.txt
>
>
> Cassandra newcomers often don't understand that they're expected to use 
> PreparedStatements for almost all of their repetitive queries executed in 
> production.
> It doesn't look like Cassandra currently expose any PreparedStatements 
> related metrics.It would be interesting, and I believe fairly simple, to add 
> several of them to make it possible, in development / management / monitoring 
> tools, to show warnings or alerts related to this bad practice.
> Thus I would suggest to add the following metrics:
> * Executed prepared statements count
> * Executed unprepared statements count
> * Amount of PreparedStatements that have been registered on the node



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to