[
https://issues.apache.org/jira/browse/CASSANDRA-7716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134049#comment-14134049
]
Benedict commented on CASSANDRA-7716:
-------------------------------------
I think the old behaviour of StressProfile.select() makes more sense...? If
you've specified a property key, but no value, that should probably fail rather
than using the default don't you think?
Otherwise LGTM, and no really strong feeling on that issue.
> cassandra-stress: provide better error messages
> -----------------------------------------------
>
> Key: CASSANDRA-7716
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7716
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Robert Stupp
> Assignee: T Jake Luciani
> Priority: Trivial
> Fix For: 2.1.1
>
> Attachments: 7166v2.txt, 7716.txt
>
>
> Just tried new stress tool.
> It would be great if the stress tool gives better error messages by telling
> the user what option or config parameter/value caused an error.
> YAML parse errors are meaningful (gives code snippets etc).
> Examples are:
> {noformat}
> WARN 16:59:39 Setting caching options with deprecated syntax.
> Exception in thread "main" java.lang.NullPointerException
> at java.util.regex.Matcher.getTextLength(Matcher.java:1234)
> at java.util.regex.Matcher.reset(Matcher.java:308)
> at java.util.regex.Matcher.<init>(Matcher.java:228)
> at java.util.regex.Pattern.matcher(Pattern.java:1088)
> at
> org.apache.cassandra.stress.settings.OptionDistribution.get(OptionDistribution.java:67)
> at
> org.apache.cassandra.stress.StressProfile.init(StressProfile.java:151)
> at
> org.apache.cassandra.stress.StressProfile.load(StressProfile.java:482)
> at
> org.apache.cassandra.stress.settings.SettingsCommandUser.<init>(SettingsCommandUser.java:53)
> at
> org.apache.cassandra.stress.settings.SettingsCommandUser.build(SettingsCommandUser.java:114)
> at
> org.apache.cassandra.stress.settings.SettingsCommand.get(SettingsCommand.java:134)
> at
> org.apache.cassandra.stress.settings.StressSettings.get(StressSettings.java:218)
> at
> org.apache.cassandra.stress.settings.StressSettings.parse(StressSettings.java:206)
> at org.apache.cassandra.stress.Stress.main(Stress.java:58)
> {noformat}
> When table-definition is wrong:
> {noformat}
> Exception in thread "main" java.lang.RuntimeException:
> org.apache.cassandra.exceptions.SyntaxException: line 6:14 mismatched input
> '(' expecting ')'
> at org.apache.cassandra.config.CFMetaData.compile(CFMetaData.java:550)
> at
> org.apache.cassandra.stress.StressProfile.init(StressProfile.java:134)
> at
> org.apache.cassandra.stress.StressProfile.load(StressProfile.java:482)
> at
> org.apache.cassandra.stress.settings.SettingsCommandUser.<init>(SettingsCommandUser.java:53)
> at
> org.apache.cassandra.stress.settings.SettingsCommandUser.build(SettingsCommandUser.java:114)
> at
> org.apache.cassandra.stress.settings.SettingsCommand.get(SettingsCommand.java:134)
> at
> org.apache.cassandra.stress.settings.StressSettings.get(StressSettings.java:218)
> at
> org.apache.cassandra.stress.settings.StressSettings.parse(StressSettings.java:206)
> at org.apache.cassandra.stress.Stress.main(Stress.java:58)
> Caused by: org.apache.cassandra.exceptions.SyntaxException: line 6:14
> mismatched input '(' expecting ')'
> at
> org.apache.cassandra.cql3.CqlParser.throwLastRecognitionError(CqlParser.java:273)
> at
> org.apache.cassandra.cql3.QueryProcessor.parseStatement(QueryProcessor.java:456)
> at org.apache.cassandra.config.CFMetaData.compile(CFMetaData.java:541)
> ... 8 more
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
