[causeway] branch ISIS-3171 updated: ISIS-3171 doc & comments amended

[joergrade]

This is an automated email from the ASF dual-hosted git repository.

joergrade pushed a commit to branch ISIS-3171
in repository https://gitbox.apache.org/repos/asf/causeway.git


The following commit(s) were added to refs/heads/ISIS-3171 by this push:
     new 4d3a05975f ISIS-3171 doc & comments amended
4d3a05975f is described below

commit 4d3a05975fd74e06b068b608f30fcadb7fb74216
Author: Jörg Rade <joerg.r...@kuehne-nagel.com>
AuthorDate: Mon Feb 27 10:11:53 2023 +0100

    ISIS-3171 doc & comments amended
---
 .../design/collection_layout_aggregation_diagram.adoc    | 16 ++++++++--------
 .../causeway/client/kroviz/core/model/PropertyDetails.kt |  5 +++--
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git 
a/incubator/clients/kroviz/adoc/modules/kroviz/partials/design/collection_layout_aggregation_diagram.adoc
 
b/incubator/clients/kroviz/adoc/modules/kroviz/partials/design/collection_layout_aggregation_diagram.adoc
index f3518142ea..39fd4b6174 100644
--- 
a/incubator/clients/kroviz/adoc/modules/kroviz/partials/design/collection_layout_aggregation_diagram.adoc
+++ 
b/incubator/clients/kroviz/adoc/modules/kroviz/partials/design/collection_layout_aggregation_diagram.adoc
@@ -94,11 +94,11 @@ together {
         readyToRender()
         addPropertyDescription()
     }
-    class ColumnSpecificationHolder <<(L,coral)Layout>> #pink{
-        columnSpecificationList
+    class CollectionLayout <<(L,coral)Layout>> #pink{
+        PropertyDetailsList
         readyToRender()
     }
-    class ColumnSpecification <<(L,coral)Layout>> #pink{
+    class PropertyDetails <<(L,coral)Layout>> #pink{
         id
         name
         hidden
@@ -108,15 +108,15 @@ together {
         readyToRender()
     }
     CollectionAggregator --> CollectionDM
-    CollectionDM --> ColumnSpecificationHolder
-    ColumnSpecificationHolder o-r-> ColumnSpecification
+    CollectionDM --> CollectionLayout
+    CollectionLayout o-r-> PropertyDetails
 }
 ObjectDM o-r-> CollectionDM
 
 ' references between Layout and TO classes
-ColumnSpecificationHolder <.. TObject : added to
-ColumnSpecificationHolder <.. ObjectProperty : added to
-ColumnSpecificationHolder <.. PropertyDescription : added to
+CollectionLayout <.. TObject : added to
+CollectionLayout <.. ObjectProperty : added to
+CollectionLayout <.. PropertyDescription : added to
 
 
 legend left
diff --git 
a/incubator/clients/kroviz/src/main/kotlin/org/apache/causeway/client/kroviz/core/model/PropertyDetails.kt
 
b/incubator/clients/kroviz/src/main/kotlin/org/apache/causeway/client/kroviz/core/model/PropertyDetails.kt
index 9da0ae4089..0f18e8e927 100644
--- 
a/incubator/clients/kroviz/src/main/kotlin/org/apache/causeway/client/kroviz/core/model/PropertyDetails.kt
+++ 
b/incubator/clients/kroviz/src/main/kotlin/org/apache/causeway/client/kroviz/core/model/PropertyDetails.kt
@@ -37,16 +37,17 @@ class PropertyDetails(member: Member) {
     private var isAmendedFromPropertyDescription = false
     var typicalLength: Int = 10
 
-
     fun amendWith(pbs: PropertyBs) {
         name = pbs.named
+        //static analysis says pbs.hidden can't be null, but runtime proves 
the opposite
         hidden = !(pbs.hidden != null && pbs.hidden.isNotEmpty())
         //This is hacky
         if (id == "sources") {
             hidden = true
         }
+        //static analysis says pbs.typicalLength  can't be null, but runtime 
proves the opposite
         if (pbs.typicalLength != null && pbs.typicalLength > 0) {
-            typicalLength = pbs.typicalLength.toInt()
+            typicalLength = pbs.typicalLength
         }
         isAmendedFromBs = true
     }