[causeway] branch 3409-mixin.eventtypes updated: CAUSEWAY-3409: resurrect ActionSemanticsFacetFallbackToNonIdempotentFactoryTest

[ahuber]

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch 3409-mixin.eventtypes
in repository https://gitbox.apache.org/repos/asf/causeway.git


The following commit(s) were added to refs/heads/3409-mixin.eventtypes by this 
push:
     new 17d8efa190 CAUSEWAY-3409: resurrect 
ActionSemanticsFacetFallbackToNonIdempotentFactoryTest
17d8efa190 is described below

commit 17d8efa1903edd74f3357e8e1407854ca23eccd7
Author: Andi Huber <ahu...@apache.org>
AuthorDate: Tue Apr 18 15:16:01 2023 +0200

    CAUSEWAY-3409: resurrect
    ActionSemanticsFacetFallbackToNonIdempotentFactoryTest
---
 ...icsFacetFallbackToNonIdempotentFactoryTest.java | 33 +++++++++++-----------
 1 file changed, 16 insertions(+), 17 deletions(-)

diff --git 
a/core/metamodel/src/test/java/org/apache/causeway/core/metamodel/facets/actions/action/ActionSemanticsFacetFallbackToNonIdempotentFactoryTest.java
 
b/core/metamodel/src/test/java/org/apache/causeway/core/metamodel/facets/actions/action/ActionSemanticsFacetFallbackToNonIdempotentFactoryTest.java
index 51f5f6a26c..9c90946dd4 100644
--- 
a/core/metamodel/src/test/java/org/apache/causeway/core/metamodel/facets/actions/action/ActionSemanticsFacetFallbackToNonIdempotentFactoryTest.java
+++ 
b/core/metamodel/src/test/java/org/apache/causeway/core/metamodel/facets/actions/action/ActionSemanticsFacetFallbackToNonIdempotentFactoryTest.java
@@ -18,10 +18,9 @@
  */
 package org.apache.causeway.core.metamodel.facets.actions.action;
 
-import java.lang.reflect.Method;
-
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -29,14 +28,14 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
 import org.apache.causeway.applib.annotation.Action;
 import org.apache.causeway.core.metamodel.facetapi.Facet;
 import 
org.apache.causeway.core.metamodel.facets.FacetFactory.ProcessMethodContext;
-import org.apache.causeway.core.metamodel.facets.FacetFactoryTestAbstract2;
+import org.apache.causeway.core.metamodel.facets.FacetFactoryTestAbstract;
 import 
org.apache.causeway.core.metamodel.facets.actions.action.semantics.ActionSemanticsFacetFallbackToNonIdempotent;
 import 
org.apache.causeway.core.metamodel.facets.actions.semantics.ActionSemanticsFacet;
 
 import lombok.val;
 
 class ActionSemanticsFacetFallbackToNonIdempotentFactoryTest
-extends FacetFactoryTestAbstract2 {
+extends FacetFactoryTestAbstract {
 
     private ActionAnnotationFacetFactory facetFactory;
 
@@ -56,22 +55,22 @@ extends FacetFactoryTestAbstract2 {
         facetFactory = null;
     }
 
-    public void testNoAnnotationPickedUp() {
+    @Test
+    void noAnnotationPickedUp() {
+        @SuppressWarnings("unused")
         class Customer {
-            @SuppressWarnings("unused")
-            public void someAction() {
-            }
+            public void someAction() {}
         }
-        final Method actionMethod = findMethod(Customer.class, "someAction");
-
-        processSemantics(facetFactory, ProcessMethodContext
-                .forTesting(Customer.class, null, actionMethod, methodRemover, 
facetedMethod));
-
-        final Facet facet = facetedMethod.getFacet(ActionSemanticsFacet.class);
-        assertNotNull(facet);
-        assertTrue(facet instanceof 
ActionSemanticsFacetFallbackToNonIdempotent);
+        actionScenario(Customer.class, "someAction", (processMethodContext, 
facetHolder, facetedMethod, facetedMethodParameter) -> {
+            //when
+            processSemantics(facetFactory, processMethodContext);
+            //then
+            final Facet facet = 
facetedMethod.getFacet(ActionSemanticsFacet.class);
+            assertNotNull(facet);
+            assertTrue(facet instanceof 
ActionSemanticsFacetFallbackToNonIdempotent);
 
-        assertNoMethodsRemoved();
+            assertNoMethodsRemoved();
+        });
     }
 
 }