This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/causeway.git
from 26e2aefa57 CAUSEWAY-2485: reworks @ActionLayout#sequence
add 187c7fcca8 CAUSEWAY-3409: simplify event-type related facets
add 2d59058704 CAUSEWAY-3409: simplify hierarchy of
DomainEventFacetAbstract
add 268779c2d4 CAUSEWAY-3409: test approvals
add 3a63024fbd CAUSEWAY-3409: further simplify hierarchy of
DomainEventFacetAbstract (coll)
add 0309ee75d7 CAUSEWAY-3409: refactor the DomainEventFacetAbstract such,
that it can receive the actual mixee during MM postprocessing and in turn hold
the correct event-type (which for mixed in members might need to be looked up
on the mixee type)
add 346d8db8d6 CAUSEWAY-3075: minor code quality
add 64595efc8b CAUSEWAY-3409: simplify further
add ddbf038626 CAUSEWAY-3409: don't install non-postable event-type
holding facets (on props+colls)
add c584f24348 CAUSEWAY-3409: simplifies hierarchy for facet
PropertySetterOrClearFacetForDomainEventAbstract
add 2cb388c1a5 CAUSEWAY-3409: further simplify event-type holding facet
hierarchy (actions)
add 11196a81dc CAUSEWAY-3409: simplify FacetFactory testing
add cb5e5c68ca CAUSEWAY-3409: cleanup some FacetFactory tests
add 500c934cc5 CAUSEWAY-3409: cleanup some FacetFactory tests (2)
add e41217e7ce CAUSEWAY-3409: cleanup some FacetFactory tests (3)
add 33fef0e06f CAUSEWAY-3409: cleanup some FacetFactory tests (4)
add fe372bc26d CAUSEWAY-3409: unify all FacetFactory test s under
FacetFactoryTestAbstract
add fd9b7d0b68 CAUSEWAY-3409: simplify FacetFactory test hierarchy (1)
add 06262e5b8e CAUSEWAY-3409: resurrecting ActionMethodsFacetFactoryTest
add 17d8efa190 CAUSEWAY-3409: resurrect
ActionSemanticsFacetFallbackToNonIdempotentFactoryTest
add 188cce724d CAUSEWAY-3409: resurrect
BookmarkableAnnotationFacetFactoryTest_action
add dcd471d46e CAUSEWAY-3409: resurrect
BookmarkableAnnotationFacetFactoryTest_class
add c984637a0c CAUSEWAY-3409: resurrect all tests from
ObjectSupportFacetFactoryTestAbstract
add fad90f8dc6 CAUSEWAY-3409: resurrect all tests from
CallbackFacetFactoryTestAbstract
add 688cf466a3 CAUSEWAY-3409: resurrect
ChoicesFacetFromBoundedAnnotationFactoryTest
add a281bcbb7c CAUSEWAY-3409: resurrect
DisabledAnnotationOnPropertyFacetFactoryTest
add 387393464c CAUSEWAY-3409: resurrect
PropertyAnnotationWithSnapshotOnPropertyFacetFactoryTest
add 61b5c7959c CAUSEWAY-3409: resurrect
PropertyOptionalityOrNullableAnnotationOnPropertyFacetFactoryTest
add 0d2d3aff41 CAUSEWAY-3409: resurrect PrototypeFacetAnnotationFactoryTest
add 7bb3dc762a CAUSEWAY-3409: resurrect MandatoryAnnotationFacetFactoryTest
add 89095a8d98 CAUSEWAY-3409: resurrect PropertyMethodsFacetFactoryTest
add a49202011a CAUSEWAY-3409: resurrect
CollectionAnnotationFacetFactoryTest_typeOf
add cea661f2b8 CAUSEWAY-3409: resurrect
CollectionFieldMethodsFacetFactoryTest
add 2c088aead0 CAUSEWAY-3409: resurrect
ParameterOptionalityOrNullableAnnotationOnParameterFacetFactoryTest
add c5049bab2e CAUSEWAY-3409: resurrect RecreatableObjectFacetFactoryTest
add f505d7b6cf CAUSEWAY-3409: resurrect
RegExAnnotationOnParameterFacetFactoryTest
add 3053010881 CAUSEWAY-3409: resurrect LayoutOrderTest
add f3fbc4d491 CAUSEWAY-3409: prepare for merge
new 434de49c5f Merge pull request #1583 from apache/3409-mixin.eventtypes
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.gitignore | 3 +
.../applib/events/domain/AbstractDomainEvent.java | 26 +-
.../applib/events/domain/ActionDomainEvent.java | 14 -
.../metamodel/facets/DomainEventFacetAbstract.java | 99 +
.../core/metamodel/facets/DomainEventHelper.java | 18 +-
.../facets/SingleClassValueFacetAbstract.java | 2 +-
.../action/ActionAnnotationFacetFactory.java | 71 +-
.../action/invocation/ActionDomainEventFacet.java | 237 +-
.../invocation/ActionDomainEventFacetAbstract.java | 154 --
.../invocation/ActionDomainEventFacetDefault.java | 32 -
.../ActionDomainEventFacetForActionAnnotation.java | 31 -
.../invocation/ActionInvocationFacetAbstract.java | 36 +-
...va => ActionInvocationFacetForDomainEvent.java} | 27 +-
...ionFacetForDomainEventFromActionAnnotation.java | 38 -
...onInvocationFacetForDomainEventFromDefault.java | 38 -
.../CollectionAnnotationFacetFactory.java | 49 +-
.../modify/CollectionDomainEventFacet.java | 149 +-
.../modify/CollectionDomainEventFacetAbstract.java | 75 -
.../modify/CollectionDomainEventFacetDefault.java | 31 -
...ionDomainEventFacetForCollectionAnnotation.java | 44 -
.../DomainObjectAnnotationFacetFactory.java | 18 +-
...EventDefaultFacetForDomainObjectAnnotation.java | 25 +-
...EventDefaultFacetForDomainObjectAnnotation.java | 24 +-
...EventDefaultFacetForDomainObjectAnnotation.java | 24 +-
.../property/PropertyAnnotationFacetFactory.java | 109 +-
....java => PropertyClearFacetForDomainEvent.java} | 15 +-
...rFacetForDomainEventFromPropertyAnnotation.java | 40 -
.../property/modify/PropertyDomainEventFacet.java | 238 +-
.../modify/PropertyDomainEventFacetAbstract.java | 168 --
.../modify/PropertyDomainEventFacetDefault.java | 39 -
...pertyDomainEventFacetForPropertyAnnotation.java | 39 -
...java => PropertySetterFacetForDomainEvent.java} | 15 +-
...rFacetForDomainEventFromPropertyAnnotation.java | 40 -
...tySetterOrClearFacetForDomainEventAbstract.java | 25 +-
.../metamodel/interactions/InteractionHead.java | 4 +-
.../TweakDomainEventsForMixinPostProcessor.java | 132 +-
.../core/metamodel/spec/feature/ObjectAction.java | 2 +-
.../AbstractFacetFactoryJupiterTestCase.java | 138 --
.../metamodel/facets/AbstractFacetFactoryTest.java | 166 --
...nEventHelperTest_newActionInteractionEvent.java | 6 +-
...HelperTest_newCollectionDomainEvent_forAdd.java | 6 +-
...perTest_newCollectionDomainEvent_forRemove.java | 6 +-
...HelperTest_newPropertyDomainEvent_forClear.java | 4 +-
...elperTest_newPropertyDomainEvent_forModify.java | 4 +-
.../metamodel/facets/FacetFactoryTestAbstract.java | 284 +++
.../causeway/core/metamodel/facets/Utils.java | 63 -
.../causeway/core/metamodel/facets/_Utils.java | 98 +
.../actions/ActionMethodsFacetFactoryTest.java | 186 +-
.../actions/IteratorFilteringFacetFactoryTest.java | 63 +-
.../action/ActionAnnotationFacetFactoryTest.java | 32 +-
...nnotationFacetFactoryTest_ActionInvocation.java | 139 +-
.../ActionAnnotationFacetFactoryTest_Hidden.java | 32 +-
...ctionAnnotationFacetFactoryTest_Invocation.java | 220 +-
...ctionAnnotationFacetFactoryTest_RestrictTo.java | 63 +-
...ActionAnnotationFacetFactoryTest_Semantics.java | 69 +-
.../ActionAnnotationFacetFactoryTest_TypeOf.java | 123 +-
...notationFacetFactoryTest_commandPublishing.java | 68 +-
...tationFacetFactoryTest_executionPublishing.java | 272 +--
...icsFacetFallbackToNonIdempotentFactoryTest.java | 47 +-
.../PrototypeFacetAnnotationFactoryTest.java | 45 +-
...kmarkableAnnotationFacetFactoryTest_action.java | 45 +-
.../ActionLayoutAnnotationFacetFactoryTest.java | 110 +-
...MenuFacetFromDomainServiceFacetFactoryTest.java | 123 +-
.../CollectionFieldMethodsFacetFactoryTest.java | 219 +-
.../CollectionAnnotationFacetFactoryTest.java | 164 +-
...ollectionAnnotationFacetFactoryTest_typeOf.java | 112 +-
.../CollectionLayoutAnnotationFactoryTest.java | 64 +-
...okmarkableAnnotationFacetFactoryTest_class.java | 44 +-
.../callback/CallbackFacetFactoryTestAbstract.java | 70 +-
.../callback/CreatedCallbackFacetFactoryTest.java | 12 +-
.../callback/LoadedCallbackFacetFactoryTest.java | 12 +-
.../PersistedCallbackFacetFactoryTest.java | 34 +-
.../PersistingCallbackFacetFactoryTest.java | 34 +-
.../callback/RemovingCallbackFacetFactoryTest.java | 32 +-
.../callback/UpdatedCallbackFacetFactoryTest.java | 12 +-
.../callback/UpdatingCallbackFacetFactoryTest.java | 12 +-
...CssClassFaFacetOnTypeAnnotationFactoryTest.java | 4 +-
.../ObjectDisabledMethodFacetFactoryTest.java | 5 +-
...oicesFacetFromBoundedAnnotationFactoryTest.java | 44 +-
.../DomainObjectAnnotationFacetFactoryTest.java | 388 +--
.../NamedAnnotationFacetFactoryTest.java | 4 +-
.../DomainObjectLayoutFactoryTest.java | 270 +--
.../DomainServiceFacetAnnotationFactoryTest.java | 40 +-
.../DomainServiceLayoutFacetFactoryTest.java | 121 +-
.../hidden/ObjectHiddenMethodFacetFactoryTest.java | 7 +-
.../cssclass/CssClassFacetMethodFactoryTest.java | 13 +-
.../ident/cssclass/CssClassFacetMethodTest.java | 12 +-
.../ident/icon/IconFacetMethodFactoryTest.java | 14 +-
.../ident/layout/LayoutFacetFactoryTest.java | 7 +-
.../title/TitleAnnotationFacetFactoryTest.java | 131 +-
.../ident/title/TitleFacetViaMethodTest.java | 8 +-
.../title/TitleFacetViaMethodsFactoryTest.java | 66 +-
.../logicaltype/LogicalTypeInferenceTest.java | 4 +-
.../NavigableParentAnnotationFacetFactoryTest.java | 24 +-
.../RecreatableObjectFacetFactoryTest.java | 50 +-
.../ObjectSupportFacetFactoryTestAbstract.java | 56 +-
.../ordering/memberorder/LayoutOrderTest.java | 136 +-
...cetForParameterLayoutAnnotationFactoryTest.java | 39 +-
...cetForParameterLayoutAnnotationFactoryTest.java | 33 +-
.../facets/param/name/ParameterNameFacetTest.java | 70 +-
.../ParameterAnnotationFacetFactoryTest.java | 313 +--
...lableAnnotationOnParameterFacetFactoryTest.java | 120 +-
...RegExAnnotationOnParameterFacetFactoryTest.java | 72 +-
.../PropertyMethodsFacetFactoryTest.java | 641 +++--
...sabledAnnotationOnPropertyFacetFactoryTest.java | 80 +-
.../MandatoryAnnotationFacetFactoryTest.java | 38 +-
.../PropertyAnnotationFacetFactoryTest.java | 695 +++---
...tionWithSnapshotOnPropertyFacetFactoryTest.java | 41 +-
...llableAnnotationOnPropertyFacetFactoryTest.java | 100 +-
.../RegExAnnotationOnPropertyFacetFactoryTest.java | 67 +-
.../PropertyLayoutAnnotationFactoryTest.java | 111 +-
.../ValueSemanticsAnnotationFacetFactoryTest.java | 250 +-
...hPdfJsViewer_IntegTest.dump_facets.approved.xml | 84 +-
..._MixinDomain_IntegTest.dump_facets.approved.xml | 84 +-
...hPdfjsViewer_IntegTest.dump_facets.approved.xml | 67 +-
...r_PropDomain_IntegTest.dump_facets.approved.xml | 67 +-
.../MetaModelRegressionTest.verify.approved.xml | 2462 ++++++++++++--------
117 files changed, 5824 insertions(+), 6378 deletions(-)
create mode 100644
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/DomainEventFacetAbstract.java
delete mode 100644
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/actions/action/invocation/ActionDomainEventFacetAbstract.java
delete mode 100644
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/actions/action/invocation/ActionDomainEventFacetDefault.java
delete mode 100644
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/actions/action/invocation/ActionDomainEventFacetForActionAnnotation.java
rename
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/actions/action/invocation/{ActionInvocationFacetForDomainEventAbstract.java
=> ActionInvocationFacetForDomainEvent.java} (92%)
delete mode 100644
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/actions/action/invocation/ActionInvocationFacetForDomainEventFromActionAnnotation.java
delete mode 100644
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/actions/action/invocation/ActionInvocationFacetForDomainEventFromDefault.java
delete mode 100644
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/collections/collection/modify/CollectionDomainEventFacetAbstract.java
delete mode 100644
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/collections/collection/modify/CollectionDomainEventFacetDefault.java
delete mode 100644
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/collections/collection/modify/CollectionDomainEventFacetForCollectionAnnotation.java
rename
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/properties/property/modify/{PropertyClearFacetForDomainEventFromDefault.java
=> PropertyClearFacetForDomainEvent.java} (74%)
delete mode 100644
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/properties/property/modify/PropertyClearFacetForDomainEventFromPropertyAnnotation.java
delete mode 100644
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/properties/property/modify/PropertyDomainEventFacetAbstract.java
delete mode 100644
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/properties/property/modify/PropertyDomainEventFacetDefault.java
delete mode 100644
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/properties/property/modify/PropertyDomainEventFacetForPropertyAnnotation.java
rename
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/properties/property/modify/{PropertySetterFacetForDomainEventFromDefault.java
=> PropertySetterFacetForDomainEvent.java} (73%)
delete mode 100644
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/properties/property/modify/PropertySetterFacetForDomainEventFromPropertyAnnotation.java
delete mode 100644
core/metamodel/src/test/java/org/apache/causeway/core/metamodel/facets/AbstractFacetFactoryJupiterTestCase.java
delete mode 100644
core/metamodel/src/test/java/org/apache/causeway/core/metamodel/facets/AbstractFacetFactoryTest.java
create mode 100644
core/metamodel/src/test/java/org/apache/causeway/core/metamodel/facets/FacetFactoryTestAbstract.java
delete mode 100644
core/metamodel/src/test/java/org/apache/causeway/core/metamodel/facets/Utils.java
create mode 100644
core/metamodel/src/test/java/org/apache/causeway/core/metamodel/facets/_Utils.java
