[causeway] branch master updated: CAUSEWAY-3408: update docs; cleanup prev. commit

[ahuber]

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/causeway.git


The following commit(s) were added to refs/heads/master by this push:
     new 3d561edc2f CAUSEWAY-3408: update docs; cleanup prev. commit
3d561edc2f is described below

commit 3d561edc2f8c732705d7e1a5e9ff334597d99f3f
Author: Andi Huber <ahu...@apache.org>
AuthorDate: Wed Apr 26 11:48:01 2023 +0200

    CAUSEWAY-3408: update docs; cleanup prev. commit
---
 .../xxxLifecycleEvent/DomainObjectXxxLifecycleEvent.java         | 9 +--------
 .../DomainObjectXxxLifecycleEventPage-description.adoc           | 2 +-
 .../xxxLifecycleEvent/jpa/DomainObjectXxxLifecycleEventJpa.java  | 5 +++--
 3 files changed, 5 insertions(+), 11 deletions(-)

diff --git 
a/examples/demo/domain/src/main/java/demoapp/dom/domain/objects/DomainObject/xxxLifecycleEvent/DomainObjectXxxLifecycleEvent.java
 
b/examples/demo/domain/src/main/java/demoapp/dom/domain/objects/DomainObject/xxxLifecycleEvent/DomainObjectXxxLifecycleEvent.java
index f8ad8fe43a..8c704ff50d 100644
--- 
a/examples/demo/domain/src/main/java/demoapp/dom/domain/objects/DomainObject/xxxLifecycleEvent/DomainObjectXxxLifecycleEvent.java
+++ 
b/examples/demo/domain/src/main/java/demoapp/dom/domain/objects/DomainObject/xxxLifecycleEvent/DomainObjectXxxLifecycleEvent.java
@@ -48,8 +48,7 @@ public abstract class DomainObjectXxxLifecycleEvent
 //end::class[]
         implements
         HasAsciiDocDescription,
-        ValueHolder<String>,
-        Comparable<DomainObjectXxxLifecycleEvent>
+        ValueHolder<String>
 //tag::class[]
 {
     public interface LifecycleEvent {                                          
             // <.>
@@ -94,12 +93,6 @@ public abstract class DomainObjectXxxLifecycleEvent
     public abstract String getName();
     public abstract void setName(String value);
 
-    @Override
-    public int compareTo(final DomainObjectXxxLifecycleEvent o) {
-        // TODO Auto-generated method stub
-        return 0;
-    }
-
 //tag::class[]
 }
 //end::class[]
diff --git 
a/examples/demo/domain/src/main/java/demoapp/dom/domain/objects/DomainObject/xxxLifecycleEvent/DomainObjectXxxLifecycleEventPage-description.adoc
 
b/examples/demo/domain/src/main/java/demoapp/dom/domain/objects/DomainObject/xxxLifecycleEvent/DomainObjectXxxLifecycleEventPage-description.adoc
index a2e7d92851..c1aacdba74 100644
--- 
a/examples/demo/domain/src/main/java/demoapp/dom/domain/objects/DomainObject/xxxLifecycleEvent/DomainObjectXxxLifecycleEventPage-description.adoc
+++ 
b/examples/demo/domain/src/main/java/demoapp/dom/domain/objects/DomainObject/xxxLifecycleEvent/DomainObjectXxxLifecycleEventPage-description.adoc
@@ -9,7 +9,7 @@ However, using 
link:https://causeway.apache.org/refguide/2.0.0-RC1/applib/index/
 * 
link:https://causeway.apache.org/refguide/2.0.0-RC1/applib/index/annotation/DomainObject.html#createdlifecycleevent[@DomainObject#createdLifecycleEvent]
 - when an entity is instantiated in memory (but not yet persisted).
 Must be a subclass of 
https://causeway.apache.org/refguide/2.0.0-RC1/applib/index/events/lifecycle/ObjectCreatedEvent[ObjectCreatedEvent].
 +
-CAUTION: the "created" lifecycle event is currently not emitted; see 
link:https://issues.apache.org/jira/browse/CAUSEWAY-3408[CAUSEWAY-3408].
+CAUTION: The new-ed up entity must be passed to (or created via) either 
`FactoryService.detachedEntity(...)` or `RepositoryService.detachedEntity(...)` 
for the 'created' lifecycle event to be fired.   
 
 * 
link:https://causeway.apache.org/refguide/2.0.0-RC1/applib/index/annotation/DomainObject.html#persistinglifecycleevent[@DomainObject#persistingLifecycleEvent]
 - when a newly instantiated entity is about to be INSERTed for the first time 
to the database.
 Must be a subclass of 
https://causeway.apache.org/refguide/2.0.0-RC1/applib/index/events/lifecycle/ObjectPersistingEvent[ObjectPersistingEvent].
diff --git 
a/examples/demo/domain/src/main/java/demoapp/dom/domain/objects/DomainObject/xxxLifecycleEvent/jpa/DomainObjectXxxLifecycleEventJpa.java
 
b/examples/demo/domain/src/main/java/demoapp/dom/domain/objects/DomainObject/xxxLifecycleEvent/jpa/DomainObjectXxxLifecycleEventJpa.java
index cbb45a21af..b71d9cc6d5 100644
--- 
a/examples/demo/domain/src/main/java/demoapp/dom/domain/objects/DomainObject/xxxLifecycleEvent/jpa/DomainObjectXxxLifecycleEventJpa.java
+++ 
b/examples/demo/domain/src/main/java/demoapp/dom/domain/objects/DomainObject/xxxLifecycleEvent/jpa/DomainObjectXxxLifecycleEventJpa.java
@@ -31,11 +31,12 @@ import org.apache.causeway.applib.annotation.DomainObject;
 import org.apache.causeway.applib.annotation.Nature;
 import 
org.apache.causeway.persistence.jpa.applib.integration.CausewayEntityListener;
 
-import 
demoapp.dom.domain.objects.DomainObject.xxxLifecycleEvent.DomainObjectXxxLifecycleEvent;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
 import lombok.Setter;
 
+import 
demoapp.dom.domain.objects.DomainObject.xxxLifecycleEvent.DomainObjectXxxLifecycleEvent;
+
 @Profile("demo-jpa")
 @Entity
 @Table(
@@ -54,7 +55,7 @@ public class DomainObjectXxxLifecycleEventJpa
     // ...
 //end::class[]
 
-    public DomainObjectXxxLifecycleEventJpa(final String value) {
+    public DomainObjectXxxLifecycleEventJpa(String value) {
         setName(value);
     }