This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/causeway.git
The following commit(s) were added to refs/heads/master by this push:
new ae08941861 CAUSEWAY-2297: remove unused imports and Eclipse
unsupported warning suppressions
ae08941861 is described below
commit ae08941861768f8fe8859c49c8ade0a5b6174411
Author: Andi Huber <[email protected]>
AuthorDate: Thu Jan 18 08:15:21 2024 +0100
CAUSEWAY-2297: remove unused imports and Eclipse unsupported warning
suppressions
---
.../applib/contributions/Object_createdByCommand.java | 6 ------
.../applib/user/dom/ApplicationUserRepositoryAbstract.java | 2 --
.../primary/ui/CommandReplayOnPrimaryService.java | 1 -
.../secondary/mixins/CommandLogEntry_replayQueue.java | 1 -
.../changetracking/EntityChangeTrackerDefault.java | 13 +++++--------
.../integration/repository/RepositoryServiceDefault.java | 7 ++-----
.../causeway/testdomain/conf/Configuration_headless.java | 4 +---
7 files changed, 8 insertions(+), 26 deletions(-)
diff --git
a/extensions/security/audittrail/applib/src/main/java/org/apache/causeway/extensions/audittrail/applib/contributions/Object_createdByCommand.java
b/extensions/security/audittrail/applib/src/main/java/org/apache/causeway/extensions/audittrail/applib/contributions/Object_createdByCommand.java
index 8e20675dee..7728c3cbdc 100644
---
a/extensions/security/audittrail/applib/src/main/java/org/apache/causeway/extensions/audittrail/applib/contributions/Object_createdByCommand.java
+++
b/extensions/security/audittrail/applib/src/main/java/org/apache/causeway/extensions/audittrail/applib/contributions/Object_createdByCommand.java
@@ -19,11 +19,8 @@
*/
package org.apache.causeway.extensions.audittrail.applib.contributions;
-import java.util.Collections;
import java.util.Comparator;
-import java.util.List;
import java.util.Optional;
-import java.util.stream.Collectors;
import javax.inject.Inject;
@@ -33,8 +30,6 @@ import org.apache.causeway.applib.annotation.MemberSupport;
import org.apache.causeway.applib.annotation.Publishing;
import org.apache.causeway.applib.annotation.SemanticsOf;
import org.apache.causeway.applib.layout.LayoutConstants;
-import org.apache.causeway.applib.services.appfeat.ApplicationFeatureId;
-import
org.apache.causeway.applib.services.appfeat.ApplicationFeatureRepository;
import org.apache.causeway.applib.services.bookmark.BookmarkService;
import org.apache.causeway.applib.services.metamodel.BeanSort;
import org.apache.causeway.applib.services.metamodel.MetaModelService;
@@ -50,7 +45,6 @@ import lombok.val;
/**
* @since 2.0 {@index}
*/
-@SuppressWarnings("CdiManagedBeanInconsistencyInspection")
@Action(
commandPublishing = Publishing.DISABLED,
domainEvent = Object_createdByCommand.ActionDomainEvent.class,
diff --git
a/extensions/security/secman/applib/src/main/java/org/apache/causeway/extensions/secman/applib/user/dom/ApplicationUserRepositoryAbstract.java
b/extensions/security/secman/applib/src/main/java/org/apache/causeway/extensions/secman/applib/user/dom/ApplicationUserRepositoryAbstract.java
index ed988696dc..d653a7c38a 100644
---
a/extensions/security/secman/applib/src/main/java/org/apache/causeway/extensions/secman/applib/user/dom/ApplicationUserRepositoryAbstract.java
+++
b/extensions/security/secman/applib/src/main/java/org/apache/causeway/extensions/secman/applib/user/dom/ApplicationUserRepositoryAbstract.java
@@ -55,7 +55,6 @@ import lombok.val;
*
* @since 2.0 {@index}
*/
-@SuppressWarnings("CdiManagedBeanInconsistencyInspection")
public class ApplicationUserRepositoryAbstract<U extends ApplicationUser>
implements ApplicationUserRepository {
@@ -67,7 +66,6 @@ implements ApplicationUserRepository {
@Inject private Provider<QueryResultsCache> queryResultsCacheProvider;
// empty if no candidate is available
- @SuppressWarnings("SpringJavaInjectionPointsAutowiringInspection")
@Autowired(required = false) @Qualifier("Secman") PasswordEncoder
passwordEncoder;
diff --git
a/incubator/extensions/core/commandreplay/primary/src/main/java/org/apache/causeway/extensions/commandreplay/primary/ui/CommandReplayOnPrimaryService.java
b/incubator/extensions/core/commandreplay/primary/src/main/java/org/apache/causeway/extensions/commandreplay/primary/ui/CommandReplayOnPrimaryService.java
index ea2e5c8a83..5e8e975dd5 100644
---
a/incubator/extensions/core/commandreplay/primary/src/main/java/org/apache/causeway/extensions/commandreplay/primary/ui/CommandReplayOnPrimaryService.java
+++
b/incubator/extensions/core/commandreplay/primary/src/main/java/org/apache/causeway/extensions/commandreplay/primary/ui/CommandReplayOnPrimaryService.java
@@ -54,7 +54,6 @@ import lombok.RequiredArgsConstructor;
/**
* @since 2.0 {@index}
*/
-@SuppressWarnings("CdiManagedBeanInconsistencyInspection")
@DomainService(
nature = NatureOfService.VIEW
)
diff --git
a/incubator/extensions/core/commandreplay/secondary/src/main/java/org/apache/causeway/extensions/commandreplay/secondary/mixins/CommandLogEntry_replayQueue.java
b/incubator/extensions/core/commandreplay/secondary/src/main/java/org/apache/causeway/extensions/commandreplay/secondary/mixins/CommandLogEntry_replayQueue.java
index 5ba869a031..a9078f9f7c 100644
---
a/incubator/extensions/core/commandreplay/secondary/src/main/java/org/apache/causeway/extensions/commandreplay/secondary/mixins/CommandLogEntry_replayQueue.java
+++
b/incubator/extensions/core/commandreplay/secondary/src/main/java/org/apache/causeway/extensions/commandreplay/secondary/mixins/CommandLogEntry_replayQueue.java
@@ -33,7 +33,6 @@ import lombok.RequiredArgsConstructor;
/**
* @since 2.0 {@index}
*/
-@SuppressWarnings("CdiManagedBeanInconsistencyInspection")
@Collection(
domainEvent = CommandLogEntry_replayQueue.CollectionDomainEvent.class
)
diff --git
a/persistence/commons/src/main/java/org/apache/causeway/persistence/commons/integration/changetracking/EntityChangeTrackerDefault.java
b/persistence/commons/src/main/java/org/apache/causeway/persistence/commons/integration/changetracking/EntityChangeTrackerDefault.java
index 430675f9d1..88a5cd49d5 100644
---
a/persistence/commons/src/main/java/org/apache/causeway/persistence/commons/integration/changetracking/EntityChangeTrackerDefault.java
+++
b/persistence/commons/src/main/java/org/apache/causeway/persistence/commons/integration/changetracking/EntityChangeTrackerDefault.java
@@ -32,12 +32,6 @@ import javax.inject.Inject;
import javax.inject.Named;
import javax.inject.Provider;
-import org.apache.causeway.core.config.CausewayConfiguration;
-import org.apache.causeway.core.runtime.flushmgmt.FlushMgmt;
-import
org.apache.causeway.persistence.commons.CausewayModulePersistenceCommons;
-
-import
org.apache.causeway.persistence.commons.integration.repository.RepositoryServiceDefault;
-
import org.springframework.beans.factory.annotation.Qualifier;
import org.springframework.core.Ordered;
import org.springframework.lang.Nullable;
@@ -62,6 +56,7 @@ import org.apache.causeway.commons.internal.base._Lazy;
import org.apache.causeway.commons.internal.collections._Maps;
import org.apache.causeway.commons.internal.collections._Sets;
import org.apache.causeway.commons.internal.exceptions._Exceptions;
+import org.apache.causeway.core.config.CausewayConfiguration;
import
org.apache.causeway.core.metamodel.facets.object.publish.entitychange.EntityChangePublishingFacet;
import org.apache.causeway.core.metamodel.object.ManagedObject;
import org.apache.causeway.core.metamodel.object.ManagedObjects;
@@ -70,10 +65,12 @@ import
org.apache.causeway.core.metamodel.services.objectlifecycle.HasEnlistedEn
import
org.apache.causeway.core.metamodel.services.objectlifecycle.PreAndPostValue;
import
org.apache.causeway.core.metamodel.services.objectlifecycle.PropertyChangeRecord;
import
org.apache.causeway.core.metamodel.services.objectlifecycle.PropertyChangeRecordId;
+import org.apache.causeway.core.runtime.flushmgmt.FlushMgmt;
import org.apache.causeway.core.transaction.changetracking.EntityChangeTracker;
import
org.apache.causeway.core.transaction.changetracking.EntityChangesPublisher;
import
org.apache.causeway.core.transaction.changetracking.EntityPropertyChangePublisher;
import
org.apache.causeway.core.transaction.changetracking.HasEnlistedEntityChanges;
+import
org.apache.causeway.persistence.commons.CausewayModulePersistenceCommons;
import lombok.AccessLevel;
import lombok.Getter;
@@ -162,7 +159,7 @@ implements
persistentChangesEncountered.set(false);
}
- private void suppressAutoFlushIfRequired(Runnable runnable) {
+ private void suppressAutoFlushIfRequired(final Runnable runnable) {
if (suppressAutoFlush) {
FlushMgmt.suppressAutoFlush(runnable);
} else {
@@ -200,7 +197,7 @@ implements
return records;
}
- private boolean shouldPublish(PreAndPostValue preAndPostValue) {
+ private boolean shouldPublish(final PreAndPostValue preAndPostValue) {
return preAndPostValueEvaluatorService.differ(preAndPostValue);
}
diff --git
a/persistence/commons/src/main/java/org/apache/causeway/persistence/commons/integration/repository/RepositoryServiceDefault.java
b/persistence/commons/src/main/java/org/apache/causeway/persistence/commons/integration/repository/RepositoryServiceDefault.java
index 26ea5fb7e3..93e1fbcf7f 100644
---
a/persistence/commons/src/main/java/org/apache/causeway/persistence/commons/integration/repository/RepositoryServiceDefault.java
+++
b/persistence/commons/src/main/java/org/apache/causeway/persistence/commons/integration/repository/RepositoryServiceDefault.java
@@ -22,18 +22,13 @@ import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.Optional;
-import java.util.concurrent.Callable;
import java.util.function.Predicate;
-import java.util.function.Supplier;
import java.util.stream.Collectors;
import javax.annotation.PostConstruct;
import javax.annotation.Priority;
import javax.inject.Named;
-import org.apache.causeway.core.runtime.flushmgmt.FlushMgmt;
-import
org.apache.causeway.persistence.commons.CausewayModulePersistenceCommons;
-
import org.springframework.beans.factory.annotation.Qualifier;
import org.springframework.lang.Nullable;
import org.springframework.stereotype.Service;
@@ -58,6 +53,8 @@ import
org.apache.causeway.core.metamodel.object.MmEntityUtils;
import org.apache.causeway.core.metamodel.object.MmUnwrapUtils;
import org.apache.causeway.core.metamodel.objectmanager.ObjectBulkLoader;
import org.apache.causeway.core.metamodel.spec.ObjectSpecification;
+import org.apache.causeway.core.runtime.flushmgmt.FlushMgmt;
+import
org.apache.causeway.persistence.commons.CausewayModulePersistenceCommons;
import lombok.Getter;
import lombok.NonNull;
diff --git
a/regressiontests/stable/src/main/java/org/apache/causeway/testdomain/conf/Configuration_headless.java
b/regressiontests/stable/src/main/java/org/apache/causeway/testdomain/conf/Configuration_headless.java
index 2e7a42a06d..fe008110b7 100644
---
a/regressiontests/stable/src/main/java/org/apache/causeway/testdomain/conf/Configuration_headless.java
+++
b/regressiontests/stable/src/main/java/org/apache/causeway/testdomain/conf/Configuration_headless.java
@@ -20,8 +20,6 @@ package org.apache.causeway.testdomain.conf;
import javax.inject.Singleton;
-import
org.apache.causeway.persistence.commons.CausewayModulePersistenceCommons;
-
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.Import;
@@ -33,9 +31,9 @@ import org.springframework.transaction.TransactionException;
import
org.springframework.transaction.support.AbstractPlatformTransactionManager;
import org.springframework.transaction.support.DefaultTransactionStatus;
-import org.apache.causeway.applib.services.metrics.MetricsService;
import org.apache.causeway.core.config.presets.CausewayPresets;
import
org.apache.causeway.core.runtimeservices.CausewayModuleCoreRuntimeServices;
+import
org.apache.causeway.persistence.commons.CausewayModulePersistenceCommons;
import org.apache.causeway.security.bypass.CausewayModuleSecurityBypass;
import
org.apache.causeway.testdomain.util.interaction.DomainObjectTesterFactory;
import org.apache.causeway.testdomain.util.kv.KVStoreForTesting;
