This is an automated email from the ASF dual-hosted git repository. danhaywood pushed a commit to branch CAUSEWAY-3676 in repository https://gitbox.apache.org/repos/asf/causeway.git
commit 72c4600f39ad888b5fbfc15a64274f95117acc68 Author: danhaywood <[email protected]> AuthorDate: Sat Jan 20 18:39:44 2024 +0000 CAUSEWAY-3676: moves responsibility to creating fieldDefinition into GqlvAction, removes redundant code --- .../viewer/graphql/model/domain/GqlvDomainService.java | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/incubator/viewers/graphql/model/src/main/java/org/apache/causeway/viewer/graphql/model/domain/GqlvDomainService.java b/incubator/viewers/graphql/model/src/main/java/org/apache/causeway/viewer/graphql/model/domain/GqlvDomainService.java index 39aa4e4e34..bdfae8f113 100644 --- a/incubator/viewers/graphql/model/src/main/java/org/apache/causeway/viewer/graphql/model/domain/GqlvDomainService.java +++ b/incubator/viewers/graphql/model/src/main/java/org/apache/causeway/viewer/graphql/model/domain/GqlvDomainService.java @@ -89,22 +89,6 @@ public class GqlvDomainService implements GqlvActionHolder, GqlvMutatorsHolder { public void addAction(final ObjectAction objectAction) { - String fieldName = objectAction.getId(); - - GraphQLFieldDefinition.Builder fieldBuilder = newFieldDefinition() - .name(fieldName) - .type((GraphQLOutputType) TypeMapper.typeForObjectAction(objectAction)); - if (objectAction.getParameters().isNotEmpty()) { - fieldBuilder.arguments(objectAction.getParameters().stream() - .map(objectActionParameter -> GraphQLArgument.newArgument() - .name(objectActionParameter.getId()) - .type(TypeMapper.inputTypeFor(objectActionParameter)) - .build()) - .collect(Collectors.toList())); - } - GraphQLFieldDefinition fieldDefinition = fieldBuilder.build(); - objectTypeBuilder.field(fieldDefinition); - // TODO: either safe or mutator safeActions.add(new GqlvAction(this, objectAction, objectTypeBuilder, codeRegistryBuilder)); }
