This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/causeway.git
The following commit(s) were added to refs/heads/master by this push:
new 221b004d83 Bump approvaltests 22.3.3->22.4.0, maven-compiler-plugin
3.11.0->3.12.1
221b004d83 is described below
commit 221b004d83f58326530ec718526043f79ed4c906
Author: Andi Huber <[email protected]>
AuthorDate: Tue Feb 27 08:26:57 2024 +0100
Bump approvaltests 22.3.3->22.4.0, maven-compiler-plugin 3.11.0->3.12.1
- along with some pom fixes
---
bom/pom.xml | 4 ++--
commons/pom.xml | 8 +++++++-
.../org/apache/causeway/commons/io/JsonUtilsTest.java | 11 +++++++++++
starters/pom.xml | 2 +-
viewers/graphql/testsupport/pom.xml | 16 +++-------------
5 files changed, 24 insertions(+), 17 deletions(-)
diff --git a/bom/pom.xml b/bom/pom.xml
index d673f75a35..fe12d2f9f2 100644
--- a/bom/pom.xml
+++ b/bom/pom.xml
@@ -77,7 +77,7 @@ It is therefore a copy of org.apache:apache, with
customisations clearly identif
<datanucleus-maven-plugin.verbose>false</datanucleus-maven-plugin.verbose>
<datanucleus-maven-plugin.fork>false</datanucleus-maven-plugin.fork>
-
<maven-compiler-plugin.version>3.11.0</maven-compiler-plugin.version>
+
<maven-compiler-plugin.version>3.12.1</maven-compiler-plugin.version>
<maven-source-plugin.version>3.2.1</maven-source-plugin.version>
<maven-surefire-plugin.version>3.0.0</maven-surefire-plugin.version>
<maven-surefire-report-plugin.version>3.2.5</maven-surefire-report-plugin.version>
@@ -89,7 +89,7 @@ It is therefore a copy of org.apache:apache, with
customisations clearly identif
<archunit.version>1.2.1</archunit.version>
<asciidoctorj.version>2.5.11</asciidoctorj.version>
<asm.version>9.6</asm.version> <!-- keep in sync with
org.eclipse.persistence:org.eclipse.persistence.asm -->
- <approvaltests.version>22.3.3</approvaltests.version>
+ <approvaltests.version>22.4.0</approvaltests.version>
<assertj-guava.version>3.25.3</assertj-guava.version>
diff --git a/commons/pom.xml b/commons/pom.xml
index 7a3b45b715..bcf40b9495 100644
--- a/commons/pom.xml
+++ b/commons/pom.xml
@@ -229,12 +229,18 @@
<artifactId>approvaltests</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <!-- required by com.approvaltests:test
+ (version manged by spring boot) -->
+ <groupId>com.google.code.gson</groupId>
+ <artifactId>gson</artifactId>
+ <scope>test</scope>
+ </dependency>
<!-- provided -->
<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
- <version>${lombok.version}</version>
<scope>provided</scope>
</dependency>
diff --git
a/commons/src/test/java/org/apache/causeway/commons/io/JsonUtilsTest.java
b/commons/src/test/java/org/apache/causeway/commons/io/JsonUtilsTest.java
index 3ce8df58ed..f012c7312a 100644
--- a/commons/src/test/java/org/apache/causeway/commons/io/JsonUtilsTest.java
+++ b/commons/src/test/java/org/apache/causeway/commons/io/JsonUtilsTest.java
@@ -30,6 +30,17 @@ import lombok.val;
class JsonUtilsTest {
+ /*
+ * [ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile
+ * on project causeway-commons: Compilation failure:
+ * [ERROR] package com.google.gson does not exist
+ * [ERROR] cannot find symbol
+ * [ERROR] symbol: class GsonBuilder
+ * [ERROR] location: class org.approvaltests.JsonApprovals
+ */
+ org.approvaltests.JsonApprovals dummy1; // references
com.google.gson.GsonBuilder
+ com.google.gson.GsonBuilder dummy2; // Requires
(GSON)[https://mvnrepository.com/artifact/com.google.code.gson/gson]
+
private Person person;
@BeforeEach
diff --git a/starters/pom.xml b/starters/pom.xml
index 2d7ab9ff7f..694c709f3b 100644
--- a/starters/pom.xml
+++ b/starters/pom.xml
@@ -49,7 +49,7 @@
<maven.compiler.release>11</maven.compiler.release>
<spring-boot.version>2.7.18</spring-boot.version>
- <approvaltests.version>22.3.3</approvaltests.version>
+ <approvaltests.version>22.4.0</approvaltests.version>
<!-- IMPORTANT: keep in sync with property defined in
resteasy-spring-boot-starter -->
<resteasy.version>5.0.0.Final</resteasy.version>
diff --git a/viewers/graphql/testsupport/pom.xml
b/viewers/graphql/testsupport/pom.xml
index 867117a6a0..122858718d 100644
--- a/viewers/graphql/testsupport/pom.xml
+++ b/viewers/graphql/testsupport/pom.xml
@@ -38,7 +38,9 @@
<maven.install.skip>true</maven.install.skip>
<maven.deploy.skip>true</maven.deploy.skip>
- <java.version>17</java.version>
+ <!-- as a minimum requirement of
+ org.springframework.graphql:spring-graphql-test:1.2.4 -->
+ <maven.compiler.release>17</maven.compiler.release>
<datasource-proxy-spring-boot-starter.version>1.8.1</datasource-proxy-spring-boot-starter.version>
<sql-formatter.version>2.0.4</sql-formatter.version>
@@ -56,22 +58,10 @@
<filtering>false</filtering>
</testResource>
</testResources>
- <plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-compiler-plugin</artifactId>
- <version>3.11.0</version>
- <configuration>
- <source>${java.version}</source>
- <target>${java.version}</target>
- </configuration>
- </plugin>
- </plugins>
</build>
<dependencies>
</dependencies>
-
</project>
