(causeway) branch master updated: CAUSEWAY-2297: fixes bugs in fakedata's random int/long generation

[ahuber]

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/causeway.git


The following commit(s) were added to refs/heads/master by this push:
     new e983ba1702 CAUSEWAY-2297: fixes bugs in fakedata's random int/long 
generation
e983ba1702 is described below

commit e983ba1702490b8977a8c2b113f7e52c254374e0
Author: Andi Huber <ahu...@apache.org>
AuthorDate: Fri Mar 1 18:10:34 2024 +0100

    CAUSEWAY-2297: fixes bugs in fakedata's random int/long generation
    
    - discovered by sonar (potential overflow)
---
 .../apache/causeway/testing/fakedata/applib/services/Integers.java   | 5 +----
 .../org/apache/causeway/testing/fakedata/applib/services/Longs.java  | 4 +---
 .../causeway/viewer/graphql/viewer/test/e2e/Admin_IntegTest.java     | 3 ---
 .../viewer/testsupport/schema/PrintSchemaIntegTestAbstract.java      | 4 +---
 4 files changed, 3 insertions(+), 13 deletions(-)

diff --git 
a/testing/fakedata/applib/src/main/java/org/apache/causeway/testing/fakedata/applib/services/Integers.java
 
b/testing/fakedata/applib/src/main/java/org/apache/causeway/testing/fakedata/applib/services/Integers.java
index 1dc4e98e0c..09507578c2 100644
--- 
a/testing/fakedata/applib/src/main/java/org/apache/causeway/testing/fakedata/applib/services/Integers.java
+++ 
b/testing/fakedata/applib/src/main/java/org/apache/causeway/testing/fakedata/applib/services/Integers.java
@@ -30,10 +30,7 @@ public class Integers extends AbstractRandomValueGenerator {
     }
 
     public int any() {
-        return fake.booleans().coinFlip()
-                ?   random().nextInt()
-                : - random().nextInt();
-
+        return random().nextInt();
     }
 
     public int upTo(final int upTo) {
diff --git 
a/testing/fakedata/applib/src/main/java/org/apache/causeway/testing/fakedata/applib/services/Longs.java
 
b/testing/fakedata/applib/src/main/java/org/apache/causeway/testing/fakedata/applib/services/Longs.java
index 0e484bcc99..2aeaf6b12d 100644
--- 
a/testing/fakedata/applib/src/main/java/org/apache/causeway/testing/fakedata/applib/services/Longs.java
+++ 
b/testing/fakedata/applib/src/main/java/org/apache/causeway/testing/fakedata/applib/services/Longs.java
@@ -30,9 +30,7 @@ public class Longs extends AbstractRandomValueGenerator {
     }
 
     public long any() {
-        return fake.booleans().coinFlip()
-                ?   random().nextLong()
-                : - random().nextLong();
+        return random().nextLong();
     }
 
     public long upTo(final long upTo) {
diff --git 
a/viewers/graphql/test/src/test/java/org/apache/causeway/viewer/graphql/viewer/test/e2e/Admin_IntegTest.java
 
b/viewers/graphql/test/src/test/java/org/apache/causeway/viewer/graphql/viewer/test/e2e/Admin_IntegTest.java
index 66f54e51d0..6867f6b07d 100644
--- 
a/viewers/graphql/test/src/test/java/org/apache/causeway/viewer/graphql/viewer/test/e2e/Admin_IntegTest.java
+++ 
b/viewers/graphql/test/src/test/java/org/apache/causeway/viewer/graphql/viewer/test/e2e/Admin_IntegTest.java
@@ -21,13 +21,10 @@ package org.apache.causeway.viewer.graphql.viewer.test.e2e;
 import java.io.IOException;
 import java.net.URISyntaxException;
 
-import org.apache.causeway.viewer.graphql.viewer.test.domain.UniversityModule;
-
 import org.junit.jupiter.api.DynamicTest;
 import org.junit.jupiter.api.Order;
 import org.junit.jupiter.api.TestFactory;
 
-import org.springframework.context.annotation.Import;
 import org.springframework.test.context.ActiveProfiles;
 
 
diff --git 
a/viewers/graphql/testsupport/src/main/java/org/apache/causeway/viewer/graphql/viewer/testsupport/schema/PrintSchemaIntegTestAbstract.java
 
b/viewers/graphql/testsupport/src/main/java/org/apache/causeway/viewer/graphql/viewer/testsupport/schema/PrintSchemaIntegTestAbstract.java
index 6bf0f1573e..3461a27357 100644
--- 
a/viewers/graphql/testsupport/src/main/java/org/apache/causeway/viewer/graphql/viewer/testsupport/schema/PrintSchemaIntegTestAbstract.java
+++ 
b/viewers/graphql/testsupport/src/main/java/org/apache/causeway/viewer/graphql/viewer/testsupport/schema/PrintSchemaIntegTestAbstract.java
@@ -26,12 +26,9 @@ import javax.inject.Inject;
 
 import graphql.schema.idl.SchemaPrinter;
 
-import org.apache.causeway.core.config.CausewayConfiguration;
-
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
-import org.springframework.test.context.DynamicPropertyRegistry;
 import org.springframework.test.context.DynamicPropertySource;
 import org.springframework.transaction.annotation.Transactional;
 
@@ -87,6 +84,7 @@ public abstract class PrintSchemaIntegTestAbstract extends 
CausewayViewerGraphql
         super(PrintSchemaIntegTestAbstract.class);
     }
 
+    @Override
     @BeforeEach
     protected void beforeEach() {
         assertNotNull(causewaySystemEnvironment);