(causeway) branch master updated: CAUSEWAY-3697: adds mignotes

[ahuber]

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/causeway.git


The following commit(s) were added to refs/heads/master by this push:
     new 7974206fdf CAUSEWAY-3697: adds mignotes
7974206fdf is described below

commit 7974206fdfc6366e5eb0ad00f39f2fffdc7a45a3
Author: Andi Huber <ahu...@apache.org>
AuthorDate: Thu Mar 14 17:07:43 2024 +0100

    CAUSEWAY-3697: adds mignotes
---
 .../relnotes/modules/ROOT/pages/2024/2.0.0/mignotes.adoc       |  8 +++++++-
 .../graphql/model/domain/common/query/CommonDomainObject.java  | 10 ++++------
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git 
a/antora/components/relnotes/modules/ROOT/pages/2024/2.0.0/mignotes.adoc 
b/antora/components/relnotes/modules/ROOT/pages/2024/2.0.0/mignotes.adoc
index 76dae4156e..dcbb06c9d8 100644
--- a/antora/components/relnotes/modules/ROOT/pages/2024/2.0.0/mignotes.adoc
+++ b/antora/components/relnotes/modules/ROOT/pages/2024/2.0.0/mignotes.adoc
@@ -5,7 +5,13 @@
 
 This page will be added to as development progresses.
 
-== Programming Model (CAUSEWAY-3692) 
+== Programming Model (CAUSEWAY-3697)
+
+Annotation attribute 
+`@DomainService(nature=..)` was marked for removal and no longer has any scope 
filtering effect. 
+This filtering is or will be replaced by some other mechanism eg. 
configuration option.
+
+== Programming Model (CAUSEWAY-3692)
 
 Annotation attribute 
 `@Parameter(dependentDefaultsPolicy=..)` was renamed to
diff --git 
a/viewers/graphql/model/src/main/java/org/apache/causeway/viewer/graphql/model/domain/common/query/CommonDomainObject.java
 
b/viewers/graphql/model/src/main/java/org/apache/causeway/viewer/graphql/model/domain/common/query/CommonDomainObject.java
index 807f96a8f5..128b12b47f 100644
--- 
a/viewers/graphql/model/src/main/java/org/apache/causeway/viewer/graphql/model/domain/common/query/CommonDomainObject.java
+++ 
b/viewers/graphql/model/src/main/java/org/apache/causeway/viewer/graphql/model/domain/common/query/CommonDomainObject.java
@@ -31,16 +31,13 @@ import static 
graphql.schema.GraphQLFieldDefinition.newFieldDefinition;
 import static graphql.schema.GraphQLInputObjectField.newInputObjectField;
 import static graphql.schema.GraphQLInputObjectType.newInputObject;
 
-import org.apache.causeway.core.config.CausewayConfiguration;
 import org.apache.causeway.core.metamodel.spec.ActionScope;
 import org.apache.causeway.core.metamodel.spec.ObjectSpecification;
 import org.apache.causeway.core.metamodel.spec.feature.MixedIn;
-import org.apache.causeway.core.metamodel.spec.feature.ObjectAction;
-import org.apache.causeway.core.metamodel.spec.feature.ObjectAssociation;
 import org.apache.causeway.viewer.graphql.model.context.Context;
-import org.apache.causeway.viewer.graphql.model.domain.Environment;
 import org.apache.causeway.viewer.graphql.model.domain.Element;
 import org.apache.causeway.viewer.graphql.model.domain.ElementCustom;
+import org.apache.causeway.viewer.graphql.model.domain.Environment;
 import org.apache.causeway.viewer.graphql.model.domain.SchemaType;
 import org.apache.causeway.viewer.graphql.model.domain.TypeNames;
 import org.apache.causeway.viewer.graphql.model.domain.common.SchemaStrategy;
@@ -74,7 +71,7 @@ public class CommonDomainObject
 
     @Getter private final GraphQLInputObjectType gqlInputObjectType;
 
-    public static String typeNameFor(SchemaStrategy schemaStrategy, 
ObjectSpecification objectSpecification) {
+    public static String typeNameFor(final SchemaStrategy schemaStrategy, 
final ObjectSpecification objectSpecification) {
         return TypeNames.objectTypeNameFor(objectSpecification, 
schemaStrategy.getSchemaType());
     }
 
@@ -126,6 +123,7 @@ public class CommonDomainObject
 
     }
 
+    @Override
     public GraphQLFieldDefinition newField(
             final String fieldName,
             final String description) {
@@ -193,7 +191,7 @@ public class CommonDomainObject
     }
 
     @Override
-    protected Object fetchData(DataFetchingEnvironment 
dataFetchingEnvironment) {
+    protected Object fetchData(final DataFetchingEnvironment 
dataFetchingEnvironment) {
         Object target = dataFetchingEnvironment.getArgument("object");
         return ObjectFeatureUtils.asPojo(getObjectSpecification(), target, new 
Environment.For(dataFetchingEnvironment), context)
                 .orElse(null);