(causeway) branch maintenance-branch updated: CAUSEWAY-3751: suppress webRequestCycle if trivial

[danhaywood]

This is an automated email from the ASF dual-hosted git repository.

danhaywood pushed a commit to branch maintenance-branch
in repository https://gitbox.apache.org/repos/asf/causeway.git


The following commit(s) were added to refs/heads/maintenance-branch by this 
push:
     new 5200e837c7 CAUSEWAY-3751: suppress webRequestCycle if trivial
5200e837c7 is described below

commit 5200e837c7cf4bd12f54440aa9b03c48da712072
Author: Dan Haywood <d...@haywood-associates.co.uk>
AuthorDate: Tue Jun 25 19:14:19 2024 +0200

    CAUSEWAY-3751: suppress webRequestCycle if trivial
---
 .../viewer/integration/WebRequestCycleForCauseway.java | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git 
a/viewers/wicket/viewer/src/main/java/org/apache/causeway/viewer/wicket/viewer/integration/WebRequestCycleForCauseway.java
 
b/viewers/wicket/viewer/src/main/java/org/apache/causeway/viewer/wicket/viewer/integration/WebRequestCycleForCauseway.java
index 5eb850fcb8..d97b5169e5 100644
--- 
a/viewers/wicket/viewer/src/main/java/org/apache/causeway/viewer/wicket/viewer/integration/WebRequestCycleForCauseway.java
+++ 
b/viewers/wicket/viewer/src/main/java/org/apache/causeway/viewer/wicket/viewer/integration/WebRequestCycleForCauseway.java
@@ -190,7 +190,6 @@ implements
 
         if(log.isDebugEnabled()) {
             timings.set(new Timing());
-            log.debug("onBeginRequest ...");
         }
     }
 
@@ -278,11 +277,18 @@ implements
 
         if(log.isDebugEnabled()) {
             val metricsServiceIfAny = 
getMetaModelContext().lookupService(MetricsService.class);
-            if(metricsServiceIfAny.isPresent()) {
-                val metricsService = metricsServiceIfAny.get();
-                log.debug("onEndRequest  took: {}ms  numberEntitiesLoaded: {}, 
numberEntitiesDirtied: {}", timings.get().took(), 
metricsService.numberEntitiesLoaded(), metricsService.numberEntitiesDirtied());
-            } else {
-                log.debug("onEndRequest  took: {}ms", timings.get().took());
+            long took = timings.get().took();
+            if(took > 50) {  // avoid too much clutter
+                if(metricsServiceIfAny.isPresent()) {
+                    val metricsService = metricsServiceIfAny.get();
+                    int numberEntitiesLoaded = 
metricsService.numberEntitiesLoaded();
+                    int numberEntitiesDirtied = 
metricsService.numberEntitiesDirtied();
+                    if(numberEntitiesLoaded > 0 || numberEntitiesDirtied > 0) {
+                        log.debug("onEndRequest  took: {}ms  
numberEntitiesLoaded: {}, numberEntitiesDirtied: {}", took, 
numberEntitiesLoaded, numberEntitiesDirtied);
+                    }
+                } else {
+                    log.debug("onEndRequest  took: {}ms", took);
+                }
             }
         }