(causeway) branch master updated: CAUSEWAY-3798: fixes page-size hinting, when table is initially 'hidden'

[ahuber]

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/causeway.git


The following commit(s) were added to refs/heads/master by this push:
     new b157961e02 CAUSEWAY-3798: fixes page-size hinting, when table is 
initially 'hidden'
b157961e02 is described below

commit b157961e022d886bfcab616374209b17e00bd712
Author: Andi Huber <ahu...@apache.org>
AuthorDate: Thu Jun 27 07:31:17 2024 +0200

    CAUSEWAY-3798: fixes page-size hinting, when table is initially 'hidden'
---
 .../wicket/model/models/EntityCollectionModelAbstract.java       | 9 +++++++++
 .../viewer/wicket/model/models/EntityCollectionModelHidden.java  | 5 -----
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git 
a/viewers/wicket/model/src/main/java/org/apache/causeway/viewer/wicket/model/models/EntityCollectionModelAbstract.java
 
b/viewers/wicket/model/src/main/java/org/apache/causeway/viewer/wicket/model/models/EntityCollectionModelAbstract.java
index f41e989c35..4a709a6b1e 100644
--- 
a/viewers/wicket/model/src/main/java/org/apache/causeway/viewer/wicket/model/models/EntityCollectionModelAbstract.java
+++ 
b/viewers/wicket/model/src/main/java/org/apache/causeway/viewer/wicket/model/models/EntityCollectionModelAbstract.java
@@ -86,6 +86,15 @@ implements EntityCollectionModel {
         return delegate().getBookmarkedOwner();
     }
 
+    /* XXX[CAUSEWAY-3798] do not override (as it was for the hidden table)
+     * Otherwise would store 1 as pags-size hint when table is initially 
hidden.
+     * We also do want to keep pags-size hints,
+     * even when switching back and forth between presentations ('table', 
'hidden'). */
+    @Override
+    public final int getPageSize() {
+        return EntityCollectionModel.super.getPageSize();
+    }
+
     // -- VARIANT SUPPORT
 
     @Override
diff --git 
a/viewers/wicket/model/src/main/java/org/apache/causeway/viewer/wicket/model/models/EntityCollectionModelHidden.java
 
b/viewers/wicket/model/src/main/java/org/apache/causeway/viewer/wicket/model/models/EntityCollectionModelHidden.java
index 3fe715ac63..9326981452 100644
--- 
a/viewers/wicket/model/src/main/java/org/apache/causeway/viewer/wicket/model/models/EntityCollectionModelHidden.java
+++ 
b/viewers/wicket/model/src/main/java/org/apache/causeway/viewer/wicket/model/models/EntityCollectionModelHidden.java
@@ -45,9 +45,4 @@ extends EntityCollectionModelAbstract {
         return "hidden";
     }
 
-    @Override
-    public int getPageSize() {
-        return 1;
-    }
-
 }