This is an automated email from the ASF dual-hosted git repository. ahuber pushed a change to branch v4 in repository https://gitbox.apache.org/repos/asf/causeway.git
from c7b2c2b85b5 CAUSEWAY-3901: logging format fix add 58be0922d00 CAUSEWAY-3889: unified icon support method add 6c8e97c6206 CAUSEWAY-3889: reinstate iconName; some CSS fixes add 4b7cceb9024 CAUSEWAY-3889: for records with @DomainObjectLayout annotation, assume bean type Viewmodel add 04dc56daa93 CAUSEWAY-3889: fixes one of prev. commits (wrong facet type) add 13766468ffd CAUSEWAY-3889: IconUiEvent to reflect new programming model new 4237d6a83fc Merge pull request #3080 from apache/3889-icon.overhaul The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../applib/annotation/DomainObjectLayout.java | 2 +- .../causeway/applib/annotation/ObjectSupport.java | 30 ++++++ .../causeway/applib/domain/DomainObjectList.java | 14 +-- .../causeway/applib/events/EventObjectBase.java | 32 +++++- .../causeway/applib/events/ui/IconUiEvent.java | 89 ++++++++--------- .../services/appfeatui/ApplicationFeatureMenu.java | 6 +- .../appfeatui/ApplicationFeatureViewModel.java | 4 +- .../applib/services/title/TitleService.java | 11 ++- .../config/beans/CausewayBeanTypeClassifier.java | 7 +- .../progmodel/ProgrammingModelConstants.java | 14 ++- .../metamodel/facets/FacetFactoryAbstract.java | 2 + .../core/metamodel/facets/ImperativeAspect.java | 19 ++++ .../members/iconfa/FaImperativeFacetAbstract.java | 60 ----------- .../members/iconfa/FaStaticFacetAbstract.java | 1 - .../FaFacetOnMemberFromConfiguredRegex.java | 110 ++++++++++++--------- ...mainObjectLayoutAnnotationUsingIconUiEvent.java | 91 ++++++++--------- .../metamodel/facets/object/icon/IconFacet.java | 8 +- .../facets/object/icon/IconFacetAbstract.java | 41 -------- .../metamodel/facets/object/icon/ObjectIcon.java | 6 +- .../facets/object/icon/ObjectIconEmbedded.java | 3 +- .../metamodel/facets/object/icon/ObjectIconFa.java | 3 +- .../facets/object/icon/ObjectIconService.java | 31 +++--- .../facets/object/icon/ObjectIconUrlBased.java | 3 +- .../method/IconFacetViaIconMethod.java} | 58 +++++------ .../icon/method/IconFacetViaIconNameMethod.java | 45 +++++---- .../ident/IconFacetFromProjectionFacet.java | 33 ++++--- .../object/support/ObjectSupportFacetFactory.java | 68 ++++++------- .../facets/object/title/TitleRenderRequest.java | 4 +- .../inspect/model/MetamodelInspectView.java | 21 ++-- .../core/metamodel/object/ManagedObject.java | 15 +-- .../services/title/TitleServiceDefault.java | 27 ++--- .../core/metamodel/spec/ObjectSpecification.java | 32 ++---- .../spec/impl/ObjectSpecificationDefault.java | 54 +++++----- .../metamodel/facets/FacetFactoryTestAbstract.java | 4 +- .../IconFacetMethodFaTest.java} | 35 ++++--- .../ident/icon/IconFacetMethodFactoryTest.java | 9 +- .../object/ident/icon/IconFacetMethodTest.java | 23 ++--- .../FontAwesomeLayersFacetMethodFactoryTest.java | 40 -------- .../ObjectSupportFacetFactoryTestAbstract.java | 5 +- .../services/title/TitleServiceDefaultTest.java | 4 +- .../mmtestsupport/MetaModelContext_forTesting.java | 3 +- ...forTesting.java => TitleServiceForTesting.java} | 22 ++--- .../icons/ObjectIconServiceDefault.java | 82 ++++++++------- .../testdomain/model/good/ProperFullyAbstract.java | 2 +- .../testdomain/model/good/ProperFullyImpl.java | 5 +- .../good/ProperMemberInheritanceAbstract.java | 4 +- .../good/ProperMemberInheritanceInterface.java | 5 +- .../interaction/DomainObjectTesterFactory.java | 11 ++- .../DomainModelTest_usingGoodDomain.java | 10 +- .../MetaModelRegressionTest.verify.approved.xml | 24 ++--- viewers/commons/model/pom.xml | 3 +- .../viewer/commons/model/mixin/HasIcon.java | 6 +- .../viewer/controller/ResourceController.java | 3 +- .../resources/DomainObjectResourceServerside.java | 3 +- .../wicket/model/models/BookmarkTreeNode.java | 2 + .../wicket/model/models/BookmarkableModel.java | 3 +- .../viewer/wicket/model/models/UiObjectWkt.java | 7 +- .../wicket/ui/components/layout/bs/col/Col.java | 7 +- .../object/icontitle/ObjectIconAndTitlePanel.java | 22 +++-- .../icontitle/ObjectIconAndTitlePanelFactory.java | 6 +- .../icontitle/ObjectIconTitleAndCopyLinkPanel.java | 7 +- .../ObjectIconTitleAndCopyLinkPanelFactory.java | 3 +- .../tree/themes/bootstrap/wkt-tree-theme.css | 4 +- .../objectsimplelink/ObjectLinkSimplePanel.css | 2 +- .../bootstrap/css/bootstrap-overrides-all-v2.css | 7 +- 65 files changed, 638 insertions(+), 679 deletions(-) delete mode 100644 core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/members/iconfa/FaImperativeFacetAbstract.java delete mode 100644 core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/object/icon/IconFacetAbstract.java rename core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/object/{iconfa/method/FaFacetViaIconFaLayersMethod.java => icon/method/IconFacetViaIconMethod.java} (52%) rename core/mmtest/src/test/java/org/apache/causeway/core/metamodel/facets/object/ident/{iconfa/FontAwesomeLayersFacetMethodTest.java => icon/IconFacetMethodFaTest.java} (66%) delete mode 100644 core/mmtest/src/test/java/org/apache/causeway/core/metamodel/facets/object/ident/iconfa/FontAwesomeLayersFacetMethodFactoryTest.java copy core/mmtestsupport/src/main/java/org/apache/causeway/core/mmtestsupport/{TranslationService_forTesting.java => TitleServiceForTesting.java} (60%)