(causeway) branch main updated: Revert "CAUSEWAY-3944: refresh entities against DB before passing them over to"

[ahuber]

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/causeway.git


The following commit(s) were added to refs/heads/main by this push:
     new 794a142e743 Revert "CAUSEWAY-3944: refresh entities against DB before 
passing them over to"
794a142e743 is described below

commit 794a142e74326eca60f68a64119bdabef95227cd
Author: andi-huber <ahu...@apache.org>
AuthorDate: Sat Nov 15 06:57:38 2025 +0100

    Revert "CAUSEWAY-3944: refresh entities against DB before passing them over 
to"
    
    This reverts commit 3904746e8142d74518cacedd5d209cb54ff76995.
---
 .../runtimeservices/executor/MemberExecutorServiceDefault.java   | 9 ---------
 .../publishing/stubs/LifecycleEventPublishingTestAbstract.java   | 2 +-
 2 files changed, 1 insertion(+), 10 deletions(-)

diff --git 
a/core/runtimeservices/src/main/java/org/apache/causeway/core/runtimeservices/executor/MemberExecutorServiceDefault.java
 
b/core/runtimeservices/src/main/java/org/apache/causeway/core/runtimeservices/executor/MemberExecutorServiceDefault.java
index 5e520090a63..bcf9d58cfb0 100644
--- 
a/core/runtimeservices/src/main/java/org/apache/causeway/core/runtimeservices/executor/MemberExecutorServiceDefault.java
+++ 
b/core/runtimeservices/src/main/java/org/apache/causeway/core/runtimeservices/executor/MemberExecutorServiceDefault.java
@@ -39,7 +39,6 @@
 import org.apache.causeway.applib.services.iactnlayer.InteractionLayerTracker;
 import org.apache.causeway.applib.services.inject.ServiceInjector;
 import org.apache.causeway.applib.services.metrics.MetricsService;
-import org.apache.causeway.applib.services.repository.RepositoryService;
 import org.apache.causeway.applib.services.xactn.TransactionService;
 import org.apache.causeway.commons.collections.Can;
 import org.apache.causeway.commons.functional.Try;
@@ -50,7 +49,6 @@
 import 
org.apache.causeway.core.config.progmodel.ProgrammingModelConstants.MessageTemplate;
 import org.apache.causeway.core.metamodel.commons.CanonicalInvoker;
 import org.apache.causeway.core.metamodel.consent.InteractionInitiatedBy;
-import org.apache.causeway.core.metamodel.context.MetaModelContext;
 import org.apache.causeway.core.metamodel.execution.ActionExecutor;
 import org.apache.causeway.core.metamodel.execution.InteractionInternal;
 import org.apache.causeway.core.metamodel.execution.MemberExecutorService;
@@ -107,7 +105,6 @@ public class MemberExecutorServiceDefault
     private final @Getter Provider<ExecutionPublisher> 
executionPublisherProvider;
     private final @Getter MetamodelEventService metamodelEventService;
     private final @Getter TransactionService transactionService;
-    private final @Getter RepositoryService repositoryService;
     private final Provider<CommandPublisher> commandPublisherProvider;
 
     private MetricsService metricsService() {
@@ -143,12 +140,6 @@ private ManagedObject invokeActionInternally(
 
         final ObjectAction owningAction = actionExecutor.getOwningAction();
         final InteractionHead head = actionExecutor.getHead();
-        
-        //CAUSEWAY-3944: make sure entities are in sync with the db before 
passing them to actions
-        if(head.owner().objSpec().isEntity()) {
-               repositoryService.refresh(head.owner().getPojo());
-        }
-        
         final Can<ManagedObject> argumentAdapters = 
actionExecutor.getArguments();
         final InteractionInitiatedBy interactionInitiatedBy = 
actionExecutor.getInteractionInitiatedBy();
         //            final MethodFacade methodFacade,
diff --git 
a/regressiontests/base/src/main/java/org/apache/causeway/testdomain/publishing/stubs/LifecycleEventPublishingTestAbstract.java
 
b/regressiontests/base/src/main/java/org/apache/causeway/testdomain/publishing/stubs/LifecycleEventPublishingTestAbstract.java
index 2ea097bdc38..ff4af66be87 100644
--- 
a/regressiontests/base/src/main/java/org/apache/causeway/testdomain/publishing/stubs/LifecycleEventPublishingTestAbstract.java
+++ 
b/regressiontests/base/src/main/java/org/apache/causeway/testdomain/publishing/stubs/LifecycleEventPublishingTestAbstract.java
@@ -180,7 +180,7 @@ protected void verify(
             case ACTION_INVOCATION: // double the book's price action -> 198.0
 
                 assertHasCreatedLifecycleEvents(Can.empty());
-                assertHasLoadedLifecycleEvents(bookSample1); //was empty 
before CAUSEWAY-3944
+                assertHasLoadedLifecycleEvents(Can.empty());
                 assertHasPersistingLifecycleEvents(Can.empty());
                 assertHasPersistedLifecycleEvents(Can.empty());
                 assertHasUpdatingLifecycleEvents(bookSample3);