(causeway) branch main updated: CAUSEWAY-2297: wrong logic in assertNumberEquals (test utils)

[ahuber]

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/causeway.git


The following commit(s) were added to refs/heads/main by this push:
     new f030a1b70ad CAUSEWAY-2297: wrong logic in assertNumberEquals (test 
utils)
f030a1b70ad is described below

commit f030a1b70adc55e97cf3160bcc17247e71765c5a
Author: andi-huber <ahu...@apache.org>
AuthorDate: Mon Dec 15 22:40:10 2025 +0100

    CAUSEWAY-2297: wrong logic in assertNumberEquals (test utils)
---
 .../causeway/commons/internal/assertions/_Assert.java     | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git 
a/commons/src/main/java/org/apache/causeway/commons/internal/assertions/_Assert.java
 
b/commons/src/main/java/org/apache/causeway/commons/internal/assertions/_Assert.java
index 1001391d22f..f51fb77726e 100644
--- 
a/commons/src/main/java/org/apache/causeway/commons/internal/assertions/_Assert.java
+++ 
b/commons/src/main/java/org/apache/causeway/commons/internal/assertions/_Assert.java
@@ -232,10 +232,9 @@ public void assertNotEmpty(final String s, final 
Supplier<String> lazyMessage) {
      * Asserts, that given {@code type} is an instance of {@code requiredType}.
      */
     public void assertTypeIsInstanceOf(final @NonNull Class<?> type, final 
@NonNull Class<?> requiredType) {
-        if(!requiredType.isAssignableFrom(type)) {
-            throw _Exceptions.assertionError(
+        if(!requiredType.isAssignableFrom(type))
+                       throw _Exceptions.assertionError(
                     "unexpected type: '%s' is not an instance of '%s' ", 
""+type, ""+requiredType);
-        }
     }
 
     /**
@@ -285,19 +284,17 @@ public void assertNumberEquals(final double a, final 
double b, final double delt
      */
     public void assertNumberEquals(final double a, final double b, final 
double delta,
             final Supplier<String> lazyMessage) {
-        if (Double.isNaN(delta) || delta < 0.0) {
-            throw _Exceptions.assertionError(
+        if (Double.isNaN(delta) || delta < 0.0)
+                       throw _Exceptions.assertionError(
                     "%sinvalid delta: '%s'",
                     _Strings.nonEmpty(lazyMessage.get()).map(msg->msg + ": 
").orElse(""),
                     String.valueOf(delta));
-        }
         if((Double.doubleToLongBits(a) != Double.doubleToLongBits(b))
-                || Math.abs(a - b) > delta) {
-            throw _Exceptions.assertionError(
+                && Math.abs(a - b) > delta)
+                       throw _Exceptions.assertionError(
                     "%snumbers %s and %s are not equal within delta %s",
                     _Strings.nonEmpty(lazyMessage.get()).map(msg->msg + ": 
").orElse(""),
                     String.valueOf(a), String.valueOf(b), 
String.valueOf(delta));
-        }
     }
 
     /**