Michael Ray Gentry created CAY-2889:
---------------------------------------

             Summary: Make subclassing a PK Generator easier
                 Key: CAY-2889
                 URL: https://issues.apache.org/jira/browse/CAY-2889
             Project: Cayenne
          Issue Type: Improvement
          Components: Core Library
            Reporter: Michael Ray Gentry
             Fix For: Undefined future


The *{{MySQLPkGenerator}}* makes two *{{super}}* calls that make subclassing 
more difficult:
 # super.pkSelectString(entityName)
 # super.pkUpdateString(entityName)

The *{{super.}}* prefix should be removed to make it easier to subclass 
*{{MySQLPkGenerator}}* since *{{pkSelectString}}* and *{{pkUpdateString}}* are 
only implemented in the superclass ({*}{{JdbcPkGenerator}}{*}) and will get 
called by default since *{{MySQLPkGenerator}}* lacks those methods, but if 
someone subclasses *{{MySQLPkGenerator}}* and adds *{{pkSelectString}}* and/or 
*{{pkUpdateString}}* then the custom subclass methods will handle that logic 
instead of *{{JdbcPkGenerator}}* once the *{{super.}}* prefix is removed.

See the developer mailing list conversation started by Robert Decker on April 
30, 2025.

Additionally, check the other PK Generator classes to see if they suffer from 
this issue.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to