This is an automated email from the ASF dual-hosted git repository.

ntimofeev pushed a commit to branch STABLE-4.2
in repository https://gitbox.apache.org/repos/asf/cayenne.git


The following commit(s) were added to refs/heads/STABLE-4.2 by this push:
     new bc1d354aa CAY-2901 Loosing comments on the existing ObjAttribute after 
DB import
bc1d354aa is described below

commit bc1d354aa34a2326f72a4a78fdd615726bb05bea
Author: Nikita Timofeev <[email protected]>
AuthorDate: Mon Oct 27 18:34:11 2025 +0400

    CAY-2901 Loosing comments on the existing ObjAttribute after DB import
---
 RELEASE-NOTES.txt                                                       | 1 +
 .../java/org/apache/cayenne/dbsync/reverse/dbimport/DbImportModule.java | 2 ++
 .../apache/cayenne/tools/dbimport/testPreserveCustomObjMappings.map.xml | 1 +
 .../cayenne/tools/dbimport/testPreserveCustomObjMappings.map.xml-result | 1 +
 4 files changed, 5 insertions(+)

diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt
index 8636d94b0..c3875de88 100644
--- a/RELEASE-NOTES.txt
+++ b/RELEASE-NOTES.txt
@@ -26,6 +26,7 @@ CAY-2896 Inserting two identical objects into two datamaps 
stores both objects i
 CAY-2898 Crypto: NPE in a ColumnQuery
 CAY-2899 CommitLog: missing lifecycle-induced changes in 
`excludeFromTransaction` mode
 CAY-2900 Meaningful generated PKs could lead to the ClassCastException
+CAY-2901 Loosing comments on the existing ObjAttribute after DB import
 
 ----------------------------------
 Release: 4.2.2
diff --git 
a/cayenne-dbsync/src/main/java/org/apache/cayenne/dbsync/reverse/dbimport/DbImportModule.java
 
b/cayenne-dbsync/src/main/java/org/apache/cayenne/dbsync/reverse/dbimport/DbImportModule.java
index f5e616e52..175e5bb45 100644
--- 
a/cayenne-dbsync/src/main/java/org/apache/cayenne/dbsync/reverse/dbimport/DbImportModule.java
+++ 
b/cayenne-dbsync/src/main/java/org/apache/cayenne/dbsync/reverse/dbimport/DbImportModule.java
@@ -34,6 +34,7 @@ import org.apache.cayenne.project.FileProjectSaver;
 import org.apache.cayenne.project.ProjectModule;
 import org.apache.cayenne.project.ProjectSaver;
 import org.apache.cayenne.project.extension.ExtensionAwareHandlerFactory;
+import org.apache.cayenne.project.extension.info.InfoExtension;
 
 /**
  * A DI module that bootstraps {@link DbImportAction}.
@@ -53,6 +54,7 @@ public class DbImportModule implements Module {
         
binder.bind(DataChannelMetaData.class).to(DefaultDataChannelMetaData.class);
         
binder.bind(HandlerFactory.class).to(ExtensionAwareHandlerFactory.class);
         
ProjectModule.contributeExtensions(binder).add(DbImportExtension.class);
+        ProjectModule.contributeExtensions(binder).add(InfoExtension.class);
     }
 
 }
diff --git 
a/maven-plugins/cayenne-maven-plugin/src/test/resources/org/apache/cayenne/tools/dbimport/testPreserveCustomObjMappings.map.xml
 
b/maven-plugins/cayenne-maven-plugin/src/test/resources/org/apache/cayenne/tools/dbimport/testPreserveCustomObjMappings.map.xml
index 23bd8e1ff..bb2d02cf0 100644
--- 
a/maven-plugins/cayenne-maven-plugin/src/test/resources/org/apache/cayenne/tools/dbimport/testPreserveCustomObjMappings.map.xml
+++ 
b/maven-plugins/cayenne-maven-plugin/src/test/resources/org/apache/cayenne/tools/dbimport/testPreserveCustomObjMappings.map.xml
@@ -29,5 +29,6 @@
     </db-entity>
     <obj-entity name="Parent" className="Parent" dbEntityName="PARENT">
         <obj-attribute name="col2" type="java.lang.String" 
db-attribute-path="COL2"/>
+        <info:property xmlns:info="http://cayenne.apache.org/schema/10/info"; 
name="comment" value="test"/>
     </obj-entity>
 </data-map>
diff --git 
a/maven-plugins/cayenne-maven-plugin/src/test/resources/org/apache/cayenne/tools/dbimport/testPreserveCustomObjMappings.map.xml-result
 
b/maven-plugins/cayenne-maven-plugin/src/test/resources/org/apache/cayenne/tools/dbimport/testPreserveCustomObjMappings.map.xml-result
index 137e471a0..305806197 100644
--- 
a/maven-plugins/cayenne-maven-plugin/src/test/resources/org/apache/cayenne/tools/dbimport/testPreserveCustomObjMappings.map.xml-result
+++ 
b/maven-plugins/cayenne-maven-plugin/src/test/resources/org/apache/cayenne/tools/dbimport/testPreserveCustomObjMappings.map.xml-result
@@ -31,5 +31,6 @@
     <obj-entity name="Parent" className="Parent" dbEntityName="PARENT">
         <obj-attribute name="col2" type="java.lang.String" 
db-attribute-path="COL2"/>
         <obj-attribute name="col4" type="java.lang.String" 
db-attribute-path="COL4"/>
+        <info:property xmlns:info="http://cayenne.apache.org/schema/10/info"; 
name="comment" value="test"/>
     </obj-entity>
 </data-map>

Reply via email to