This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch branch-0.2
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git
The following commit(s) were added to refs/heads/branch-0.2 by this push:
new bfdab970 [CELEBORN-304] Missing setIfMissing
`celeborn.$module.io.serverThreads` (#1238)
bfdab970 is described below
commit bfdab97056c72ffdc6ed53bbc1b8108569d486aa
Author: jiaoqingbo <[email protected]>
AuthorDate: Wed Feb 15 15:49:08 2023 +0800
[CELEBORN-304] Missing setIfMissing `celeborn.$module.io.serverThreads`
(#1238)
---
.../spark/sql/execution/columnar/RssCompressibleColumnBuilder.scala | 2 +-
common/src/main/scala/org/apache/celeborn/common/util/Utils.scala | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
a/client-spark/spark-3/src/main/scala/org/apache/spark/sql/execution/columnar/RssCompressibleColumnBuilder.scala
b/client-spark/spark-3/src/main/scala/org/apache/spark/sql/execution/columnar/RssCompressibleColumnBuilder.scala
index 9188b0a3..45603708 100644
---
a/client-spark/spark-3/src/main/scala/org/apache/spark/sql/execution/columnar/RssCompressibleColumnBuilder.scala
+++
b/client-spark/spark-3/src/main/scala/org/apache/spark/sql/execution/columnar/RssCompressibleColumnBuilder.scala
@@ -44,7 +44,7 @@ trait RssCompressibleColumnBuilder[T <: AtomicType]
// The various compression schemes, while saving memory use, cause all of
the data within
// the row to become unaligned, thus causing crashes. Until a way of fixing
the compression
- // is found to also allow aligned accesses this must be disabled for SPARC.
+ // is found to also allow aligned accesses this must be disabled for SPARK.
protected def isWorthCompressing(encoder: Encoder[T]) = {
RssCompressibleColumnBuilder.unaligned && encoder.compressionRatio < 0.8
diff --git a/common/src/main/scala/org/apache/celeborn/common/util/Utils.scala
b/common/src/main/scala/org/apache/celeborn/common/util/Utils.scala
index ac6d5f05..67fd6a80 100644
--- a/common/src/main/scala/org/apache/celeborn/common/util/Utils.scala
+++ b/common/src/main/scala/org/apache/celeborn/common/util/Utils.scala
@@ -497,7 +497,7 @@ object Utils extends Logging {
// assuming we have all the machine's cores).
// NB: Only set if serverThreads/clientThreads not already set.
val numThreads = defaultNumThreads(numUsableCores)
- conf.setIfMissing(s"celeborn.$module.io.clientThreads",
numThreads.toString)
+ conf.setIfMissing(s"celeborn.$module.io.serverThreads",
numThreads.toString)
conf.setIfMissing(s"celeborn.$module.io.clientThreads",
numThreads.toString)
// TODO remove after releasing 0.2.0
conf.setIfMissing(s"rss.$module.io.serverThreads", numThreads.toString)
