[incubator-celeborn] branch main updated: [CELEBORN-323] readBuffers need synchronized as recycle buffer will call readers in multiple threads (#1256)

[ethanfeng]

This is an automated email from the ASF dual-hosted git repository.

ethanfeng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git


The following commit(s) were added to refs/heads/main by this push:
     new 1b1517c7 [CELEBORN-323] readBuffers need synchronized as recycle 
buffer will call readers in multiple threads (#1256)
1b1517c7 is described below

commit 1b1517c7b4eb94e214325e077bb17d6e046c85b1
Author: Shuang <lvshuang...@gmail.com>
AuthorDate: Tue Feb 21 15:58:19 2023 +0800

    [CELEBORN-323] readBuffers need synchronized as recycle buffer will call 
readers in multiple threads (#1256)
---
 .../apache/celeborn/common/network/server/BufferStreamManager.java  | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git 
a/common/src/main/java/org/apache/celeborn/common/network/server/BufferStreamManager.java
 
b/common/src/main/java/org/apache/celeborn/common/network/server/BufferStreamManager.java
index feb21202..2ede302b 100644
--- 
a/common/src/main/java/org/apache/celeborn/common/network/server/BufferStreamManager.java
+++ 
b/common/src/main/java/org/apache/celeborn/common/network/server/BufferStreamManager.java
@@ -260,7 +260,7 @@ public class BufferStreamManager {
       readBuffers();
     }
 
-    public void readBuffers() {
+    public synchronized void readBuffers() {
       PriorityQueue<DataPartitionReader> sortedReaders = new 
PriorityQueue<>(readers);
       while (buffers.size() > 0 && !sortedReaders.isEmpty()) {
         DataPartitionReader reader = sortedReaders.poll();
@@ -279,9 +279,7 @@ public class BufferStreamManager {
       readExecutor.submit(
           () -> {
             // Key for IO schedule.
-            synchronized (MapDataPartition.this) {
-              readBuffers();
-            }
+            readBuffers();
           });
     }