This is an automated email from the ASF dual-hosted git repository.

rexxiong pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git


The following commit(s) were added to refs/heads/main by this push:
     new 45503238b [CELEBORN-657][BUG] DataPushQueue return task should always 
remove iterator
45503238b is described below

commit 45503238b39cb6f39942a9b8a48224b7edb44533
Author: Angerszhuuuu <[email protected]>
AuthorDate: Fri Jun 9 13:37:07 2023 +0800

    [CELEBORN-657][BUG] DataPushQueue return task should always remove iterator
    
    ### What changes were proposed in this pull request?
     DataPushQueue return task should always remove iterator
    Related to
    
https://github.com/apache/incubator-celeborn/commit/251b923b5beb0bd13cdf8059a39edc7d6e435364
    
https://github.com/apache/incubator-celeborn/commit/cb19ed1c66a8ece834fc6aea10b8b57627d2eec6
    
    ### Why are the changes needed?
    
    ### Does this PR introduce _any_ user-facing change?
    
    ### How was this patch tested?
    
    Closes #1568 from AngersZhuuuu/CELEBORN-657.
    
    Authored-by: Angerszhuuuu <[email protected]>
    Signed-off-by: Shuang <[email protected]>
---
 .../src/main/java/org/apache/celeborn/client/write/DataPushQueue.java   | 2 ++
 1 file changed, 2 insertions(+)

diff --git 
a/client/src/main/java/org/apache/celeborn/client/write/DataPushQueue.java 
b/client/src/main/java/org/apache/celeborn/client/write/DataPushQueue.java
index 4741bb700..244746dac 100644
--- a/client/src/main/java/org/apache/celeborn/client/write/DataPushQueue.java
+++ b/client/src/main/java/org/apache/celeborn/client/write/DataPushQueue.java
@@ -112,9 +112,11 @@ public class DataPushQueue {
               workerCapacity.put(loc.hostAndPushPort(), oldCapacity - 1);
             }
           } else {
+            iterator.remove();
             tasks.add(task);
           }
         } else {
+          iterator.remove();
           tasks.add(task);
         }
       }

Reply via email to