This is an automated email from the ASF dual-hosted git repository.
zhouky pushed a commit to branch branch-0.3
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git
The following commit(s) were added to refs/heads/branch-0.3 by this push:
new 0ffc59f61 [CELEBORN-668][FOLLOWUP] Handle unknown worker should also
reply WorkerLostResponse
0ffc59f61 is described below
commit 0ffc59f61b329f1ad874df1d098e7d7c5c3a3c48
Author: Angerszhuuuu <[email protected]>
AuthorDate: Fri Jun 16 17:45:57 2023 +0800
[CELEBORN-668][FOLLOWUP] Handle unknown worker should also reply
WorkerLostResponse
### What changes were proposed in this pull request?
Now worker will send WorkLost too, master should also reply
WorkerLostResponse when it's unknown worker
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
Closes #1584 from AngersZhuuuu/CELEBORN-668-FOLLOWUP.
Lead-authored-by: Angerszhuuuu <[email protected]>
Co-authored-by: Keyong Zhou <[email protected]>
Signed-off-by: zky.zhoukeyong <[email protected]>
(cherry picked from commit ec2959fccbb3e65c2d2a0bb7d2e2fd3197e9084f)
Signed-off-by: zky.zhoukeyong <[email protected]>
---
.../scala/org/apache/celeborn/service/deploy/master/Master.scala | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
a/master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala
b/master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala
index 714b78a11..351ff56f4 100644
---
a/master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala
+++
b/master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala
@@ -464,11 +464,9 @@ private[celeborn] class Master(
if (worker == null) {
logWarning(s"Unknown worker
$host:$rpcPort:$pushPort:$fetchPort:$replicatePort" +
s" for WorkerLost handler!")
- return
+ } else {
+ statusSystem.handleWorkerLost(host, rpcPort, pushPort, fetchPort,
replicatePort, requestId)
}
-
- statusSystem.handleWorkerLost(host, rpcPort, pushPort, fetchPort,
replicatePort, requestId)
-
if (context != null) {
context.reply(WorkerLostResponse(true))
}
