This is an automated email from the ASF dual-hosted git repository.

zhouky pushed a commit to branch branch-0.3
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git


The following commit(s) were added to refs/heads/branch-0.3 by this push:
     new 9e3a53011 [CELEBORN-729] Fix typo PbRegisterShuffle#numMappers
9e3a53011 is described below

commit 9e3a53011fb37ba05d24563c4af6fb0be612d496
Author: Cheng Pan <[email protected]>
AuthorDate: Wed Jun 28 18:28:34 2023 +0800

    [CELEBORN-729] Fix typo PbRegisterShuffle#numMappers
    
    ### What changes were proposed in this pull request?
    
    Fix typo `numMapppers`, should be `numMappers`
    
    ### Why are the changes needed?
    
    Fix typo
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    Protobuf serde depends on message field seq no, not name.
    
    Closes #1642 from pan3793/CELEBORN-729.
    
    Authored-by: Cheng Pan <[email protected]>
    Signed-off-by: zky.zhoukeyong <[email protected]>
    (cherry picked from commit 3d7c1fa0ae1deed8abca8951bd0193486301c700)
    Signed-off-by: zky.zhoukeyong <[email protected]>
---
 client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala | 2 +-
 common/src/main/proto/TransportMessages.proto                           | 2 +-
 .../org/apache/celeborn/common/protocol/message/ControlMessages.scala   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala 
b/client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala
index 4b4a01535..3e43d7b72 100644
--- a/client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala
+++ b/client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala
@@ -207,7 +207,7 @@ class LifecycleManager(val appUniqueId: String, val conf: 
CelebornConf) extends
   override def receiveAndReply(context: RpcCallContext): PartialFunction[Any, 
Unit] = {
     case pb: PbRegisterShuffle =>
       val shuffleId = pb.getShuffleId
-      val numMappers = pb.getNumMapppers
+      val numMappers = pb.getNumMappers
       val numPartitions = pb.getNumPartitions
       logDebug(s"Received RegisterShuffle request, " +
         s"$shuffleId, $numMappers, $numPartitions.")
diff --git a/common/src/main/proto/TransportMessages.proto 
b/common/src/main/proto/TransportMessages.proto
index b4f6a0c60..c484d8224 100644
--- a/common/src/main/proto/TransportMessages.proto
+++ b/common/src/main/proto/TransportMessages.proto
@@ -155,7 +155,7 @@ message PbHeartbeatResponse {
 
 message PbRegisterShuffle {
   int32 shuffleId = 1;
-  int32 numMapppers = 2;
+  int32 numMappers = 2;
   int32 numPartitions = 3;
 }
 
diff --git 
a/common/src/main/scala/org/apache/celeborn/common/protocol/message/ControlMessages.scala
 
b/common/src/main/scala/org/apache/celeborn/common/protocol/message/ControlMessages.scala
index 8afbe07b8..2aa9096b6 100644
--- 
a/common/src/main/scala/org/apache/celeborn/common/protocol/message/ControlMessages.scala
+++ 
b/common/src/main/scala/org/apache/celeborn/common/protocol/message/ControlMessages.scala
@@ -125,7 +125,7 @@ object ControlMessages extends Logging {
         numPartitions: Int): PbRegisterShuffle =
       PbRegisterShuffle.newBuilder()
         .setShuffleId(shuffleId)
-        .setNumMapppers(numMappers)
+        .setNumMappers(numMappers)
         .setNumPartitions(numPartitions)
         .build()
   }

Reply via email to