This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git
The following commit(s) were added to refs/heads/main by this push:
new 63f22342e [CELEBORN-730] Remove unused SlaveLostResponse
63f22342e is described below
commit 63f22342e92de666dede05f08281c26a63ddb7ef
Author: Angerszhuuuu <[email protected]>
AuthorDate: Wed Jun 28 19:35:23 2023 +0800
[CELEBORN-730] Remove unused SlaveLostResponse
### What changes were proposed in this pull request?
Remove unused SlaveLostResponse
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
Closes #1644 from AngersZhuuuu/CELEBORN-730.
Authored-by: Angerszhuuuu <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
---
common/src/main/proto/TransportMessages.proto | 7 +------
.../common/protocol/message/ControlMessages.scala | 15 ---------------
2 files changed, 1 insertion(+), 21 deletions(-)
diff --git a/common/src/main/proto/TransportMessages.proto
b/common/src/main/proto/TransportMessages.proto
index c484d8224..6ed80b7ff 100644
--- a/common/src/main/proto/TransportMessages.proto
+++ b/common/src/main/proto/TransportMessages.proto
@@ -52,7 +52,7 @@ enum MessageType {
COMMIT_FILES_RESPONSE = 31;
DESTROY = 32;
DESTROY_RESPONSE = 33;
- SLAVE_LOST_RESPONSE = 34;
+ // SLAVE_LOST_RESPONSE = 34;
GET_WORKER_INFO = 35;
GET_WORKER_INFO_RESPONSE = 36;
THREAD_DUMP = 37;
@@ -385,11 +385,6 @@ message PbDestroyWorkerSlotsResponse {
repeated string failedSlaves = 3;
}
-message PbSlaveLostResponse {
- int32 status = 1;
- PbPartitionLocation slaveLocation = 2;
-}
-
message PbGetWorkerInfosResponse {
int32 status = 1;
repeated PbWorkerInfo workerInfos = 2;
diff --git
a/common/src/main/scala/org/apache/celeborn/common/protocol/message/ControlMessages.scala
b/common/src/main/scala/org/apache/celeborn/common/protocol/message/ControlMessages.scala
index 2aa9096b6..3fbff5d81 100644
---
a/common/src/main/scala/org/apache/celeborn/common/protocol/message/ControlMessages.scala
+++
b/common/src/main/scala/org/apache/celeborn/common/protocol/message/ControlMessages.scala
@@ -420,8 +420,6 @@ object ControlMessages extends Logging {
* common
* ==========================================
*/
- case class SlaveLostResponse(status: StatusCode, slaveLocation:
PartitionLocation) extends Message
-
case object GetWorkerInfos extends Message
case class GetWorkerInfosResponse(status: StatusCode, workerInfos:
WorkerInfo*) extends Message
@@ -785,13 +783,6 @@ object ControlMessages extends Logging {
val payload = builder.build().toByteArray
new TransportMessage(MessageType.DESTROY_RESPONSE, payload)
- case SlaveLostResponse(status, slaveLocation) =>
- val payload = PbSlaveLostResponse.newBuilder()
- .setStatus(status.getValue)
- .setSlaveLocation(PbSerDeUtils.toPbPartitionLocation(slaveLocation))
- .build().toByteArray
- new TransportMessage(MessageType.SLAVE_LOST_RESPONSE, payload)
-
case GetWorkerInfos =>
new TransportMessage(MessageType.GET_WORKER_INFO, null)
@@ -1099,12 +1090,6 @@ object ControlMessages extends Logging {
pbDestroyResponse.getFailedMastersList,
pbDestroyResponse.getFailedSlavesList)
- case SLAVE_LOST_RESPONSE =>
- val pbSlaveLostResponse =
PbSlaveLostResponse.parseFrom(message.getPayload)
- SlaveLostResponse(
- Utils.toStatusCode(pbSlaveLostResponse.getStatus),
-
PbSerDeUtils.fromPbPartitionLocation(pbSlaveLostResponse.getSlaveLocation))
-
case GET_WORKER_INFO =>
GetWorkerInfos