[incubator-celeborn] branch main updated: [CELEBORN-734] Remove unused RPC ReregisterWorkerResonse

[angerszhuuuu]

This is an automated email from the ASF dual-hosted git repository.

angerszhuuuu pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git


The following commit(s) were added to refs/heads/main by this push:
     new a672db719 [CELEBORN-734] Remove unused RPC ReregisterWorkerResonse
a672db719 is described below

commit a672db719a5b2eb3be43f26b52cfc6c321fa15b0
Author: Angerszhuuuu <angers....@gmail.com>
AuthorDate: Wed Jun 28 19:59:53 2023 +0800

    [CELEBORN-734] Remove unused RPC ReregisterWorkerResonse
    
    ### What changes were proposed in this pull request?
    Remove unused RPC ReregisterWorkerResonse
    
    ### Why are the changes needed?
    
    ### Does this PR introduce _any_ user-facing change?
    
    ### How was this patch tested?
    
    Closes #1646 from AngersZhuuuu/CELEBORN-734.
    
    Authored-by: Angerszhuuuu <angers....@gmail.com>
    Signed-off-by: Angerszhuuuu <angers....@gmail.com>
---
 common/src/main/proto/TransportMessages.proto                |  6 +-----
 .../celeborn/common/protocol/message/ControlMessages.scala   | 12 ------------
 2 files changed, 1 insertion(+), 17 deletions(-)

diff --git a/common/src/main/proto/TransportMessages.proto 
b/common/src/main/proto/TransportMessages.proto
index 29c73595a..e6bfd9372 100644
--- a/common/src/main/proto/TransportMessages.proto
+++ b/common/src/main/proto/TransportMessages.proto
@@ -45,7 +45,7 @@ enum MessageType {
   CHECK_QUOTA_RESPONSE = 24;
   REPORT_WORKER_FAILURE = 25;
   REGISTER_WORKER_RESPONSE = 26;
-  REREGISTER_WORKER_RESPONSE = 27;
+  // REREGISTER_WORKER_RESPONSE = 27;
   RESERVE_SLOTS = 28;
   RESERVE_SLOTS_RESPONSE = 29;
   COMMIT_FILES = 30;
@@ -329,10 +329,6 @@ message PbRegisterWorkerResponse {
   string message = 2;
 }
 
-message PbReregisterWorkerResponse {
-  bool success = 1;
-}
-
 message PbReserveSlots {
   string applicationId = 1;
   int32 shuffleId = 2;
diff --git 
a/common/src/main/scala/org/apache/celeborn/common/protocol/message/ControlMessages.scala
 
b/common/src/main/scala/org/apache/celeborn/common/protocol/message/ControlMessages.scala
index 8c66a0a15..ca2cc52ad 100644
--- 
a/common/src/main/scala/org/apache/celeborn/common/protocol/message/ControlMessages.scala
+++ 
b/common/src/main/scala/org/apache/celeborn/common/protocol/message/ControlMessages.scala
@@ -360,8 +360,6 @@ object ControlMessages extends Logging {
         .build()
   }
 
-  case class ReregisterWorkerResponse(success: Boolean) extends WorkerMessage
-
   case class ReserveSlots(
       applicationId: String,
       shuffleId: Int,
@@ -688,12 +686,6 @@ object ControlMessages extends Logging {
     case pb: PbRegisterWorkerResponse =>
       new TransportMessage(MessageType.REGISTER_WORKER_RESPONSE, 
pb.toByteArray)
 
-    case ReregisterWorkerResponse(success) =>
-      val payload = PbReregisterWorkerResponse.newBuilder()
-        .setSuccess(success)
-        .build().toByteArray
-      new TransportMessage(MessageType.REREGISTER_WORKER_RESPONSE, payload)
-
     case ReserveSlots(
           applicationId,
           shuffleId,
@@ -1008,10 +1000,6 @@ object ControlMessages extends Logging {
       case REGISTER_WORKER_RESPONSE =>
         PbRegisterWorkerResponse.parseFrom(message.getPayload)
 
-      case REREGISTER_WORKER_RESPONSE =>
-        val pbReregisterWorkerResponse = 
PbReregisterWorkerResponse.parseFrom(message.getPayload)
-        ReregisterWorkerResponse(pbReregisterWorkerResponse.getSuccess)
-
       case RESERVE_SLOTS =>
         val pbReserveSlots = PbReserveSlots.parseFrom(message.getPayload)
         val userIdentifier = 
PbSerDeUtils.fromPbUserIdentifier(pbReserveSlots.getUserIdentifier)