This is an automated email from the ASF dual-hosted git repository.

zhouky pushed a commit to branch branch-0.3
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git


The following commit(s) were added to refs/heads/branch-0.3 by this push:
     new 1ad703485 [CELEBORN-740] Remove usage of AccessController
1ad703485 is described below

commit 1ad703485435c5d4e087f5b55b0849673ac60839
Author: Cheng Pan <[email protected]>
AuthorDate: Thu Jun 29 10:21:02 2023 +0800

    [CELEBORN-740] Remove usage of AccessController
    
    ### What changes were proposed in this pull request?
    
    Remove usage of deprecated `java.security.AccessController`
    
    ### Why are the changes needed?
    
    `AccessController` is deprecated for removal since Java 17
    
    
https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/security/AccessController.html
    
    Recover building for Java 17
    
    ```
    [INFO] compiling 72 Scala sources and 209 Java sources to 
/home/runner/work/incubator-celeborn/incubator-celeborn/common/target/classes 
...
    Error:  
/home/runner/work/incubator-celeborn/incubator-celeborn/common/src/main/scala/org/apache/celeborn/common/serializer/SerializationDebugger.scala:71:
 class AccessController in package security is deprecated
    Error: [ERROR] one error found
    ```
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    ```
    scala> System.getProperty("java.version")
    res0: String = 1.8.0_332
    
    scala> System.getProperty("sun.io.serialization.extendedDebugInfo")
    res1: String = null
    
    scala> 
java.lang.Boolean.getBoolean("sun.io.serialization.extendedDebugInfo")
    res2: Boolean = false
    ```
    
    Closes #1652 from pan3793/CELEBORN-740.
    
    Authored-by: Cheng Pan <[email protected]>
    Signed-off-by: zky.zhoukeyong <[email protected]>
    (cherry picked from commit c33aabfa37dc876d03132e53e29d3c1c0063719d)
    Signed-off-by: zky.zhoukeyong <[email protected]>
---
 .../apache/celeborn/common/serializer/SerializationDebugger.scala    | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git 
a/common/src/main/scala/org/apache/celeborn/common/serializer/SerializationDebugger.scala
 
b/common/src/main/scala/org/apache/celeborn/common/serializer/SerializationDebugger.scala
index f3bb4d6ed..13ef55319 100644
--- 
a/common/src/main/scala/org/apache/celeborn/common/serializer/SerializationDebugger.scala
+++ 
b/common/src/main/scala/org/apache/celeborn/common/serializer/SerializationDebugger.scala
@@ -18,8 +18,8 @@
 package org.apache.celeborn.common.serializer
 
 import java.io._
+import java.lang.{Boolean => JBoolean}
 import java.lang.reflect.{Field, Method}
-import java.security.AccessController
 
 import scala.annotation.tailrec
 import scala.collection.mutable
@@ -68,8 +68,7 @@ private[celeborn] object SerializationDebugger extends 
Logging {
   }
 
   private[serializer] var enableDebugging: Boolean = {
-    !AccessController.doPrivileged(new sun.security.action.GetBooleanAction(
-      "sun.io.serialization.extendedDebugInfo")).booleanValue()
+    !JBoolean.getBoolean("sun.io.serialization.extendedDebugInfo")
   }
 
   private class SerializationDebugger {

Reply via email to