This is an automated email from the ASF dual-hosted git repository.
zhouky pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git
The following commit(s) were added to refs/heads/main by this push:
new 2ffd6d7b2 [CELEBORN-905] Redraw the flowchart backpressure.svg after
worker pause logic is reconstructed
2ffd6d7b2 is described below
commit 2ffd6d7b289c287f3ae49f120dbf963b7b57ffe0
Author: zwangsheng <[email protected]>
AuthorDate: Thu Aug 24 11:51:01 2023 +0800
[CELEBORN-905] Redraw the flowchart backpressure.svg after worker pause
logic is reconstructed
### What changes were proposed in this pull request?
Add a new `backpressure.svg` to replace the out-date one.
### Why are the changes needed?
After #1811, we refactor celeborn worker back-pressure logic, we should add
new flowchart for user to understand.
### Does this PR introduce _any_ user-facing change?
Yes
### How was this patch tested?

Closes #1829 from zwangsheng/CELEBORN-905.
Authored-by: zwangsheng <[email protected]>
Signed-off-by: zky.zhoukeyong <[email protected]>
---
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala | 2 +-
docs/assets/img/backpressure.svg | 2 +-
docs/configuration/worker.md | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git
a/common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
b/common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
index 764b11217..65e55ef51 100644
--- a/common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
+++ b/common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
@@ -2474,7 +2474,7 @@ object CelebornConf extends Logging {
.doc("If direct memory usage is less than this limit, worker will
resume.")
.version("0.2.0")
.doubleConf
- .createWithDefault(0.5)
+ .createWithDefault(0.7)
val WORKER_CONGESTION_CONTROL_ENABLED: ConfigEntry[Boolean] =
buildConf("celeborn.worker.congestionControl.enabled")
diff --git a/docs/assets/img/backpressure.svg b/docs/assets/img/backpressure.svg
index 67596a081..9463f2369 100644
--- a/docs/assets/img/backpressure.svg
+++ b/docs/assets/img/backpressure.svg
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<!-- Do not edit this file with editors other than draw.io -->
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN"
"http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
-<svg xmlns="http://www.w3.org/2000/svg"
xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1" width="448px"
height="556px" viewBox="-0.5 -0.5 448 556" content="<mxfile
host="app.diagrams.net" modified="2023-07-24T09:54:28.825Z"
agent="Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/114.0.0.0 Safari/537.36"
etag="muQwWoZ1AV76Lv06bOp7" version="21.6.5"
type="device"> < [...]
\ No newline at end of file
+<svg xmlns="http://www.w3.org/2000/svg"
xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1" width="961px"
height="391px" viewBox="-0.5 -0.5 961 391" content="<mxfile
host="app.diagrams.net" modified="2023-08-24T03:16:36.635Z"
agent="Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36"
etag="jf3rkS_hW_dt-9T37uvz" version="21.6.9"
type="device"><diagra [...]
\ No newline at end of file
diff --git a/docs/configuration/worker.md b/docs/configuration/worker.md
index f846268cd..994838b3f 100644
--- a/docs/configuration/worker.md
+++ b/docs/configuration/worker.md
@@ -39,7 +39,7 @@ license: |
| celeborn.worker.directMemoryRatioForReadBuffer | 0.1 | Max ratio of direct
memory for read buffer | 0.2.0 |
| celeborn.worker.directMemoryRatioToPauseReceive | 0.85 | If direct memory
usage reaches this limit, the worker will stop to receive data from Celeborn
shuffle clients. | 0.2.0 |
| celeborn.worker.directMemoryRatioToPauseReplicate | 0.95 | If direct memory
usage reaches this limit, the worker will stop to receive replication data from
other workers. This value should be higher than
celeborn.worker.directMemoryRatioToPauseReceive. | 0.2.0 |
-| celeborn.worker.directMemoryRatioToResume | 0.5 | If direct memory usage is
less than this limit, worker will resume. | 0.2.0 |
+| celeborn.worker.directMemoryRatioToResume | 0.7 | If direct memory usage is
less than this limit, worker will resume. | 0.2.0 |
| celeborn.worker.fetch.heartbeat.enabled | false | enable the heartbeat from
worker to client when fetching data | 0.3.0 |
| celeborn.worker.fetch.io.threads | <undefined> | Netty IO thread
number of worker to handle client fetch data. The default threads number is the
number of flush thread. | 0.2.0 |
| celeborn.worker.fetch.port | 0 | Server port for Worker to receive fetch
data request from ShuffleClient. | 0.2.0 |