This is an automated email from the ASF dual-hosted git repository.
ethanfeng pushed a commit to branch branch-0.3
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git
The following commit(s) were added to refs/heads/branch-0.3 by this push:
new 8af579a85 [MINOR] Adjust log level for
`PushDataHandler#checkDiskFullAndSplit` from debug to trace
8af579a85 is described below
commit 8af579a85bd264bcc8ef4f86231c6d12b62d7a20
Author: Fu Chen <[email protected]>
AuthorDate: Fri Oct 20 16:26:16 2023 +0800
[MINOR] Adjust log level for `PushDataHandler#checkDiskFullAndSplit` from
debug to trace
### What changes were proposed in this pull request?
As title
### Why are the changes needed?
This PR modifies the log level from debug to trace for the
`PushDataHandler#checkDiskFullAndSplit` method, which is invoked with each
`PushData` request. This change is aimed at addressing the issue of excessive
log volume caused by the high frequency of `PushData` requests.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass GA
Closes #2007 from cfmcgrady/check-disk-full-and-split-log-level.
Authored-by: Fu Chen <[email protected]>
Signed-off-by: mingji <[email protected]>
(cherry picked from commit 5b6e19706495e96631f5e3a1037481a2c42f7de0)
Signed-off-by: mingji <[email protected]>
---
.../org/apache/celeborn/service/deploy/worker/PushDataHandler.scala | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
a/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala
b/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala
index 0a201439a..62edc2a93 100644
---
a/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala
+++
b/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala
@@ -1209,11 +1209,11 @@ class PushDataHandler extends BaseMessageHandler with
Logging {
softSplit: AtomicBoolean,
callback: RpcResponseCallback): Boolean = {
val diskFull = checkDiskFull(fileWriter)
- logDebug(
+ logTrace(
s"""
|CheckDiskFullAndSplit in
|diskFull:$diskFull,
- |partitionSplitMinimumSize: $partitionSplitMinimumSize,
+ |partitionSplitMinimumSize:$partitionSplitMinimumSize,
|splitThreshold:${fileWriter.getSplitThreshold()},
|fileLength:${fileWriter.getFileInfo.getFileLength}
|fileName:${fileWriter.getFileInfo.getFilePath}
@@ -1225,7 +1225,7 @@ class PushDataHandler extends BaseMessageHandler with
Logging {
softSplit.set(true)
} else {
callback.onSuccess(ByteBuffer.wrap(Array[Byte](StatusCode.HARD_SPLIT.getValue)))
- logDebug(
+ logTrace(
s"""
|CheckDiskFullAndSplit hardSplit
|diskFull:$diskFull,
